components/page_load_metrics/browser/metrics_web_contents_observer.h - Issue 1916913008: This patch uses the WebContents' opener to extract the previous committed url for the very first na…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 1916913008: This patch uses the WebContents' opener to extract the previous committed url for the very first na… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.h

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h

index f18b126d4940c1e9afdbc3e679f2d4df1d705a5c..b01d5df2c6315c424cec6b4af0323bb72f3c12f2 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h

@@ -111,7 +111,7 @@ class PageLoadTracker {

// the constructor.

PageLoadTracker(bool in_foreground,

PageLoadMetricsEmbedderInterface* embedder_interface,

- PageLoadTracker* const currently_committed_load_or_null,

+ const GURL& currently_committed_url,

content::NavigationHandle* navigation_handle,

int aborted_chain_size,

int aborted_chain_size_same_url);

@@ -292,6 +292,9 @@ class MetricsWebContentsObserver

scoped_ptr<PageLoadTracker> committed_load_;

+ // Has the MWCO observed at least one navigation?

+ bool has_navigated_;

DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);

};