Issue 1916893002: Code completion progress part two of fix to https://github.com/dart-lang/sdk/issues/24254, addition…

Issue 1916893002: Code completion progress part two of fix to https://github.com/dart-lang/sdk/issues/24254, addition… (Closed)

Created:
4 years, 7 months ago by jwren

Modified:
4 years, 7 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org, scheglov

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Code completion progress part two of fix to https://github.com/dart-lang/sdk/issues/24254, addition of new contributor, variable_name_contributor.dart. The completions are not yet showing up in either IDE, IntelliJ or Atom. BUG=https://github.com/dart-lang/sdk/issues/24254 R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/e01634bd7912e564e90a05e979eae677eb135fed

Patch Set 2 : Comment from danrubel #

Patch Set 3 : merge with bleeding_edge #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+352 lines, -19 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/optype.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart	View	1	1 chunk	+94 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/name_suggestion.dart	View		5 chunks	+19 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/optype_test.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/test_all.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	pkg/analysis_server/test/services/completion/dart/variable_name_contributor_test.dart	View		1 chunk	+199 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

LGTM https://codereview.chromium.org/1916893002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart File pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart (right): https://codereview.chromium.org/1916893002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart#newcode51 pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart:51: // then resolve the outermost/entire expression Remove comment ...

4 years, 7 months ago (2016-04-25 19:46:41 UTC) #3

jwren

https://codereview.chromium.org/1916893002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart File pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart (right): https://codereview.chromium.org/1916893002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart#newcode51 pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart:51: // then resolve the outermost/entire expression On 2016/04/25 19:46:41, ...

4 years, 7 months ago (2016-04-25 19:49:38 UTC) #4

jwren

4 years, 7 months ago (2016-04-25 19:51:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
e01634bd7912e564e90a05e979eae677eb135fed (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages