Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: pkg/analysis_server/test/services/completion/dart/optype_test.dart

Issue 1916893002: Code completion progress part two of fix to https://github.com/dart-lang/sdk/issues/24254, addition… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge with bleeding_edge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/optype_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/optype_test.dart b/pkg/analysis_server/test/services/completion/dart/optype_test.dart
index 971ed026efa04ae4c8b2959f3c0c3e91a1fb2ce3..f5c89bbfe1141799fbad1c52ad12f993a5c74697 100644
--- a/pkg/analysis_server/test/services/completion/dart/optype_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/optype_test.dart
@@ -1427,10 +1427,21 @@ class C2 {
test_TopLevelVariableDeclaration_typed_name() {
// SimpleIdentifier VariableDeclaration VariableDeclarationList
// TopLevelVariableDeclaration
+ // _OpTypeAstVisitor.visitVariableDeclarationList is executed with this
+ // source, but _OpTypeAstVisitor.visitTopLevelVariableDeclaration is called
+ // for test_TopLevelVariableDeclaration_typed_name_semicolon
addTestSource('class A {} B ^');
assertOpType(varNames: true);
}
+ test_TopLevelVariableDeclaration_typed_name_semicolon() {
+ // SimpleIdentifier VariableDeclaration VariableDeclarationList
+ // TopLevelVariableDeclaration
+ // See comment in test_TopLevelVariableDeclaration_typed_name
+ addTestSource('class A {} B ^;');
+ assertOpType(varNames: true);
+ }
+
test_TopLevelVariableDeclaration_untyped_name() {
// SimpleIdentifier VariableDeclaration VariableDeclarationList
// TopLevelVariableDeclaration

Powered by Google App Engine
This is Rietveld 408576698