Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1916793002: Revert of Call SkGraphics::Init() automatically for Google3 processes. (Closed)

Created:
4 years, 8 months ago by dogben
Modified:
4 years, 8 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Call SkGraphics::Init() automatically for Google3 processes. (patchset #1 id:1 of https://codereview.chromium.org/1906813002/ ) Reason for revert: Fixed in a different way in internal cl/120632580. Original issue's description: > Call SkGraphics::Init() automatically for Google3 processes. > > This is logically a partial revert of https://codereview.chromium.org/1903503002. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906813002 > > Committed: https://skia.googlesource.com/skia/+/868060602975834c33eb33a937545c6af8ac8395 TBR=mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/98ab04012d56ebc931132506f431131ad1102c91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/core/SkGraphics.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dogben
Created Revert of Call SkGraphics::Init() automatically for Google3 processes.
4 years, 8 months ago (2016-04-25 14:18:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916793002/1
4 years, 8 months ago (2016-04-25 14:18:05 UTC) #2
mtklein
lgtm
4 years, 8 months ago (2016-04-25 14:18:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916793002/1
4 years, 8 months ago (2016-04-25 14:31:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:33:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/98ab04012d56ebc931132506f431131ad1102c91

Powered by Google App Engine
This is Rietveld 408576698