Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1906813002: Call SkGraphics::Init() automatically for Google3 processes. (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 7 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Call SkGraphics::Init() automatically for Google3 processes. This is logically a partial revert of https://codereview.chromium.org/1903503002. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906813002 Committed: https://skia.googlesource.com/skia/+/868060602975834c33eb33a937545c6af8ac8395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/core/SkGraphics.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
4 years, 8 months ago (2016-04-21 13:04:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906813002/1
4 years, 8 months ago (2016-04-21 13:04:38 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-21 13:04:39 UTC) #7
dogben
lgtm This looks good to get the roll going again, but I think long-term we ...
4 years, 8 months ago (2016-04-21 14:00:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/868060602975834c33eb33a937545c6af8ac8395
4 years, 8 months ago (2016-04-21 14:01:22 UTC) #10
dogben
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1916793002/ by benjaminwagner@google.com. ...
4 years, 7 months ago (2016-04-25 14:18:02 UTC) #11
dogben
4 years, 7 months ago (2016-04-25 14:19:05 UTC) #12
Message was sent while issue was closed.
On 2016/04/25 at 14:18:02, Ben Wagner wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1916793002/ by benjaminwagner@google.com.
> 
> The reason for reverting is: Fixed in a different way in internal
cl/20632580..

cl/120632580

Powered by Google App Engine
This is Rietveld 408576698