Prepare for move-only PassOwnPtr in the remaining directories.

Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349
Committed: https://crrev.com/7f32753bce23595c54633f13592f768823e324ba
Cr-Commit-Position: refs/heads/master@{#389744}

[Yuta Kitamura, 2016-04-25 06:50:32]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 06:50:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/1

[commit-bot: I haz the power, 2016-04-25 06:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 06:53:16]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Yuta Kitamura, 2016-04-25 11:37:11]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 11:37:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/20001

[Yuta Kitamura, 2016-04-25 11:37:43]

Description was changed from

==========
Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349
==========

to

==========
Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349
==========

[Yuta Kitamura, 2016-04-25 11:37:43]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2016-04-25 11:37:44]

yutak@chromium.org changed required reviewers:
+ haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2016-04-25 11:38:53]

PTAL?

+tzik for general review
+tkent for approval for changes in public/platform
+haraken for approval for changes elsewhere

[haraken, 2016-04-25 11:44:42]

LGTM

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp
(right):

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp:23:
base::WorkerPool::PostTask(baseLocation, base::Bind(&RunBackgroundTask,
base::Passed(std::unique_ptr<CrossThreadClosure>(closure.leakPtr()))), taskSize
== TaskSizeLongRunningTask);

so complicated...

But this is the only place to post a task to base::WorkerPool. So it would be
okay.

[commit-bot: I haz the power, 2016-04-25 12:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 12:12:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tzik, 2016-04-25 12:22:33]

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp
(right):

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp:23:
base::WorkerPool::PostTask(baseLocation, base::Bind(&RunBackgroundTask,
base::Passed(std::unique_ptr<CrossThreadClosure>(closure.leakPtr()))), taskSize
== TaskSizeLongRunningTask);
Can we use base::Owned(closure.leakPtr()) here?

[jbroman, 2016-04-25 15:08:27]

Drive-by question, sorry.

Normally we pass PassOwnPtr by value rather than by rvalue reference; if these
must be this way it would be nice to have a comment explaining why.

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebContentSettingCallbacks.h (right):

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebContentSettingCallbacks.h:32:
BLINK_PLATFORM_EXPORT
WebContentSettingCallbacks(WTF::PassOwnPtr<ContentSettingCallbacks>&&);
drive-by: why PassOwnPtr<T>&& and not PassOwnPtr<T>?

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebFileSystemCallbacks.h (right):

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebFileSystemCallbacks.h:67:
BLINK_PLATFORM_EXPORT
WebFileSystemCallbacks(WTF::PassOwnPtr<AsyncFileSystemCallbacks>&&);
ditto

[Yuta Kitamura, 2016-04-26 02:55:36]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 02:55:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/20001

[Yuta Kitamura, 2016-04-26 02:57:29]

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebContentSettingCallbacks.h (right):

https://codereview.chromium.org/1916703002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebContentSettingCallbacks.h:32:
BLINK_PLATFORM_EXPORT
WebContentSettingCallbacks(WTF::PassOwnPtr<ContentSettingCallbacks>&&);
On 2016/04/25 15:08:27, jbroman wrote:
> drive-by: why PassOwnPtr<T>&& and not PassOwnPtr<T>?

That's explained in the change description.

[tkent, 2016-04-26 03:04:19]

lgtm.

BTW, it's ok to include PassOwnPtr.h in public headers, like

#if INSIDE_BLINK
#include "wtf/PassOwnPtr.h"
#endif

[commit-bot: I haz the power, 2016-04-26 03:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 03:30:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuta Kitamura, 2016-04-26 06:08:35]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 06:08:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/60001

[commit-bot: I haz the power, 2016-04-26 06:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 06:10:43]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yuta Kitamura, 2016-04-26 07:00:38]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 07:00:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/80001

[Yuta Kitamura, 2016-04-26 07:10:53]

tzik: PTAL at PS2:5?

Re PassOwnPtr<T>&&, I'd like to keep the rvalue reference,
because that roughly corresponds to what the existing code
does (const PassOwnPtr& to avoid PassOwnPtr definition).

[commit-bot: I haz the power, 2016-04-26 08:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 08:22:46]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Yuta Kitamura, 2016-04-26 08:28:26]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 08:28:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/80001

[tzik, 2016-04-26 09:08:17]

lgtm

[commit-bot: I haz the power, 2016-04-26 10:35:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 10:35:21]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-04-26 10:52:00]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-04-26 10:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1916703002/#ps80001
(title: "Merge with trunk.")

[commit-bot: I haz the power, 2016-04-26 10:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916703002/80001

[commit-bot: I haz the power, 2016-04-26 10:56:53]

Description was changed from

==========
Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349
==========

to

==========
Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349
==========

[commit-bot: I haz the power, 2016-04-26 10:56:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-26 10:57:45]

Description was changed from

==========
Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349
==========

to

==========
Prepare for move-only PassOwnPtr in the remaining directories.

The changes are mechanical and mostly trivial; they will usually fall
under one of the following buckets:

* Adding std::move() in a place where copying of PassOwnPtr takes place.
* Adding passed() for a callback argument that will be "auto-passed" to
  the function.
* Remove const from PassOwnPtr<T> type, since that will be incompatible
  with move-only PassOwnPtr.

There are a few unusual instances:

* platform/network/ResourceTimingInfo.h: The CrossThreadCopier
  specialization needs to return a PassedWrapper<> object.
* platform/threading/BackgroundTaskRunner.cpp: Convert PassOwnPtr
  to std::unique_ptr; additional use of base::Passed requires a new
  DEPS entry.
* wtf/Functional.h: It is sufficient to receive a PassOwnPtr as a const
  reference.
* public/WebContentSettingCallbacks.h and
  public/WebFileSystemCallbacks.h: These headers cannot include
  PassOwnPtr.h, so the functions declared there must take a PassOwnPtr
  as an rvalue reference.

All these changes are no-op for now, but will be necessary when
PassOwnPtr becomes move-only.

BUG=582349

Committed: https://crrev.com/7f32753bce23595c54633f13592f768823e324ba
Cr-Commit-Position: refs/heads/master@{#389744}
==========

[commit-bot: I haz the power, 2016-04-26 10:57:48]

Patchset 5 (id:??) landed as
https://crrev.com/7f32753bce23595c54633f13592f768823e324ba
Cr-Commit-Position: refs/heads/master@{#389744}