third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp - Issue 1916703002: Prepare for move-only PassOwnPtr in the remaining directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp

Issue 1916703002: Prepare for move-only PassOwnPtr in the remaining directories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@core1

Patch Set: Merge with trunk. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp ('k') | third_party/WebKit/Source/platform/threading/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp

diff --git a/third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp b/third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp

index c75e7e8302daeffc9e4c27cf163c493988d3229b..f365bdc3210fbb01ba68bad5f6c3395ba1ad5127 100644

--- a/third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp

+++ b/third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp

@@ -5,13 +5,14 @@

#include "platform/threading/BackgroundTaskRunner.h"

#include "base/bind.h"

+#include "base/bind_helpers.h"

#include "base/location.h"

#include "base/threading/worker_pool.h"

#include "public/platform/WebTraceLocation.h"

namespace blink {

-static void RunBackgroundTask(PassOwnPtr<CrossThreadClosure> closure)

+static void RunBackgroundTask(CrossThreadClosure* closure)

{

(*closure)();

}

@@ -19,7 +20,7 @@ static void RunBackgroundTask(PassOwnPtr<CrossThreadClosure> closure)

void BackgroundTaskRunner::postOnBackgroundThread(const WebTraceLocation& location, PassOwnPtr<CrossThreadClosure> closure, TaskSize taskSize)

{

tracked_objects::Location baseLocation(location.functionName(), location.fileName(), 0, nullptr);

- base::WorkerPool::PostTask(baseLocation, base::Bind(&RunBackgroundTask, closure), taskSize == TaskSizeLongRunningTask);

+ base::WorkerPool::PostTask(baseLocation, base::Bind(&RunBackgroundTask, base::Owned(closure.leakPtr())), taskSize == TaskSizeLongRunningTask);

}

} // namespace blink