Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 1916573002: Revert "Treat percent-height div inside auto-height cells as auto" (Closed)

Created:
4 years, 8 months ago by dgrogan
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert "Treat percent-height div inside auto-height cells as auto" This reverts commit 8876584335b48c99cf8df552ef4d8efebb131041. Even though this aligned us better with the spec and FF in some cases, it broke too many others. E.g. it broke http://jsfiddle.net/dgrogan/rp9htqks/6/ - Edge, Chrome 49 and FF all have a green square, chrome 50.0.2661.75 does not. Compare to the test case that originally spurred this change http://jsfiddle.net/pCx89/4/ BUG=603507, 353580 Review URL: https://codereview.chromium.org/1899053002 Cr-Commit-Position: refs/heads/master@{#388899} (cherry picked from commit a3d77052c868e6f31cb4da867f641e64f47ab3e2) Committed: https://chromium.googlesource.com/chromium/src/+/1a12f4d422ff4389e32aa29414aa62b263c5eb24

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
dgrogan
4 years, 8 months ago (2016-04-22 20:58:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a12f4d422ff4389e32aa29414aa62b263c5eb24.

Powered by Google App Engine
This is Rietveld 408576698