Revert "Treat percent-height div inside auto-height cells as auto"

Revert "Treat percent-height div inside auto-height cells as auto"

This reverts commit 8876584335b48c99cf8df552ef4d8efebb131041.

Even though this aligned us better with the spec and FF in some cases, it
broke too many others.

E.g. it broke http://jsfiddle.net/dgrogan/rp9htqks/6/ - Edge, Chrome 49
and FF all have a green square, chrome 50.0.2661.75 does not.

Compare to the test case that originally spurred this change
http://jsfiddle.net/pCx89/4/

BUG=603507, 353580
Committed: https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2
Cr-Commit-Position: refs/heads/master@{#388899}

[dgrogan, 2016-04-19 00:05:49]

dgrogan@chromium.org changed reviewers:
+ eae@chromium.org, mstensho@opera.com

[dgrogan, 2016-04-19 00:05:50]

Hi Emil, Morten,

I'll submit on the first review. And then merge to stable and beta.

I'll also compare to the outline Francois Remy posted[1] in response to this
breakage and see if I can rework this change.

Christian, thanks for helping me wrangle this.

[1] https://lists.w3.org/Archives/Public/www-style/2016Apr/0289.html

[mstensho (USE GERRIT), 2016-04-19 07:02:48]

lgtm

[dgrogan, 2016-04-19 15:22:02]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-04-19 15:22:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899053002/1

[eae, 2016-04-19 15:24:47]

LGTM

[commit-bot: I haz the power, 2016-04-19 16:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 16:43:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgrogan, 2016-04-20 00:02:00]

Patchset #2 (id:20001) has been deleted

[dgrogan, 2016-04-20 22:12:58]

Morten, I'm going to wait until you comment or re-lgtm before submitting.

I'm not sure why these two tests have to be rebaselined: neither Edge nor FF
show a blue rectangle. But it appears to be a separate bug than the one this
change tried to address. This change was just a huge sledgehammer that covered
up the newly-discovered bug.

This bug: pct height children of auto table-cells should be auto.
Newly-discovered bug: table-cell height is set to 20px for some reason unknown
to me.

[mstensho (USE GERRIT), 2016-04-21 06:06:30]

On 2016/04/20 22:12:58, dgrogan wrote:
> Morten, I'm going to wait until you comment or re-lgtm before submitting.
> 
> I'm not sure why these two tests have to be rebaselined: neither Edge nor FF
> show a blue rectangle. But it appears to be a separate bug than the one this
> change tried to address. This change was just a huge sledgehammer that covered
> up the newly-discovered bug.
> 
> This bug: pct height children of auto table-cells should be auto.
> Newly-discovered bug: table-cell height is set to 20px for some reason unknown
> to me.

re-lgtm. These tests landed after your fix, and they use percent height things
inside auto-height cells, so it's fine that your revert affects them.

[dgrogan, 2016-04-21 14:02:32]

The CQ bit was checked by dgrogan@chromium.org

[dgrogan, 2016-04-21 14:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1899053002/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-04-21 14:02:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899053002/40001

[commit-bot: I haz the power, 2016-04-21 14:12:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 14:12:55]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgrogan, 2016-04-21 16:52:15]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-04-21 16:52:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899053002/40001

[commit-bot: I haz the power, 2016-04-21 19:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:29:07]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgrogan, 2016-04-21 19:30:57]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:31:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899053002/40001

[commit-bot: I haz the power, 2016-04-21 21:06:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:39:34]

Description was changed from

==========
Revert "Treat percent-height div inside auto-height cells as auto"

This reverts commit 8876584335b48c99cf8df552ef4d8efebb131041.

Even though this aligned us better with the spec and FF in some cases, it
broke too many others.

E.g. it broke http://jsfiddle.net/dgrogan/rp9htqks/6/ - Edge, Chrome 49
and FF all have a green square, chrome 50.0.2661.75 does not.

Compare to the test case that originally spurred this change
http://jsfiddle.net/pCx89/4/

BUG=603507,353580
==========

to

==========
Revert "Treat percent-height div inside auto-height cells as auto"

This reverts commit 8876584335b48c99cf8df552ef4d8efebb131041.

Even though this aligned us better with the spec and FF in some cases, it
broke too many others.

E.g. it broke http://jsfiddle.net/dgrogan/rp9htqks/6/ - Edge, Chrome 49
and FF all have a green square, chrome 50.0.2661.75 does not.

Compare to the test case that originally spurred this change
http://jsfiddle.net/pCx89/4/

BUG=603507,353580

Committed: https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2
Cr-Commit-Position: refs/heads/master@{#388899}
==========

[commit-bot: I haz the power, 2016-04-22 19:39:35]

Patchset 2 (id:??) landed as
https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2
Cr-Commit-Position: refs/heads/master@{#388899}