Add automatic generation of mipmaps to Vulkan

Add automatic generation of mipmaps to Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916563002

Committed: https://skia.googlesource.com/skia/+/62340067270c5c3365afa6b40b8e995ae6a6c1ec

[jvanverth1, 2016-04-22 20:38:35]

Description was changed from

==========
Add automatic generation of mipmaps to Vulkan

BUG=skia:
==========

to

==========
Add automatic generation of mipmaps to Vulkan

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-04-25 16:48:59]

jvanverth@google.com changed reviewers:
+ egdaniel@google.com

[jvanverth1, 2016-04-25 19:27:10]

The results appear to be identical to those prior -- which is a bit puzzling to
me. I have verified that it is both generating and using the mipmaps. Perhaps
the driver's doing something tricky behind the scenes.

[egdaniel, 2016-04-25 21:01:09]

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkPipelin...
File src/gpu/vk/GrVkPipelineState.cpp (right):

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkPipelin...
src/gpu/vk/GrVkPipelineState.cpp:302:
texture->texturePriv().setMaxMipMapLevel(mipLevels);
can this be done in generateMipmap? Might be able to avoid calling
ComputeLevelCount again.

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkSampler...
File src/gpu/vk/GrVkSampler.cpp (right):

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkSampler...
src/gpu/vk/GrVkSampler.cpp:62: createInfo.maxLod = (float)(mipLevels);
need to check if mipLevels is 1 then this should be 0

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkTexture...
File src/gpu/vk/GrVkTexture.cpp (right):

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkTexture...
src/gpu/vk/GrVkTexture.cpp:181: uint32_t mipLevels =
SkMipMap::ComputeLevelCount(this->width(), this->height());
if mipLevels == 1 should we just return here? I guess returning false?

[jvanverth1, 2016-04-26 14:18:26]

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkPipelin...
File src/gpu/vk/GrVkPipelineState.cpp (right):

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkPipelin...
src/gpu/vk/GrVkPipelineState.cpp:302:
texture->texturePriv().setMaxMipMapLevel(mipLevels);
On 2016/04/25 21:01:09, egdaniel wrote:
> can this be done in generateMipmap? Might be able to avoid calling
> ComputeLevelCount again.

Done.

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkSampler...
File src/gpu/vk/GrVkSampler.cpp (right):

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkSampler...
src/gpu/vk/GrVkSampler.cpp:62: createInfo.maxLod = (float)(mipLevels);
On 2016/04/25 21:01:09, egdaniel wrote:
> need to check if mipLevels is 1 then this should be 0

Done.

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkTexture...
File src/gpu/vk/GrVkTexture.cpp (right):

https://codereview.chromium.org/1916563002/diff/120001/src/gpu/vk/GrVkTexture...
src/gpu/vk/GrVkTexture.cpp:181: uint32_t mipLevels =
SkMipMap::ComputeLevelCount(this->width(), this->height());
On 2016/04/25 21:01:09, egdaniel wrote:
> if mipLevels == 1 should we just return here? I guess returning false?

Done.

[egdaniel, 2016-04-26 14:21:57]

lgtm

[jvanverth1, 2016-04-26 14:28:31]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-04-26 14:28:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916563002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916563002/140001

[commit-bot: I haz the power, 2016-04-26 15:01:46]

Description was changed from

==========
Add automatic generation of mipmaps to Vulkan

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add automatic generation of mipmaps to Vulkan

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/62340067270c5c3365afa6b40b8e995ae6a6c1ec
==========

[commit-bot: I haz the power, 2016-04-26 15:01:47]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/62340067270c5c3365afa6b40b8e995ae6a6c1ec