Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: src/debug/debug-evaluate.cc

Issue 1916413002: [debugger] fix crash in debug-evaluate when retrieving values in TDZ. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5.0
Patch Set: fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-version.h ('k') | test/mjsunit/regress/regress-crbug-605581.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-evaluate.cc
diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc
index 1134c9dd68ae9cfec97deb3a1bed09c7663a6d61..8114c21fe856842c40ca63aa64edfdd4e1e4cd78 100644
--- a/src/debug/debug-evaluate.cc
+++ b/src/debug/debug-evaluate.cc
@@ -346,6 +346,7 @@ void DebugEvaluate::ContextBuilder::MaterializeContextChain(
// within debug-evaluate.
continue;
}
+ if (value->IsTheHole()) continue; // Value is not initialized yet (in TDZ).
JSObject::SetOwnPropertyIgnoreAttributes(target, name, value, NONE).Check();
}
}
« no previous file with comments | « include/v8-version.h ('k') | test/mjsunit/regress/regress-crbug-605581.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698