Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: test/mjsunit/regress/regress-crbug-605581.js

Issue 1916413002: [debugger] fix crash in debug-evaluate when retrieving values in TDZ. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5.0
Patch Set: fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-crbug-605581.js
diff --git a/test/mjsunit/regress/regress-4309-2.js b/test/mjsunit/regress/regress-crbug-605581.js
similarity index 51%
copy from test/mjsunit/regress/regress-4309-2.js
copy to test/mjsunit/regress/regress-crbug-605581.js
index 984b0071c135fd5037d252128d290d7bcc8669cc..0f1daabead95a6357503f418c5b46c710ba6b99b 100644
--- a/test/mjsunit/regress/regress-4309-2.js
+++ b/test/mjsunit/regress/regress-crbug-605581.js
@@ -1,34 +1,28 @@
-// Copyright 2015 the V8 project authors. All rights reserved.
+// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --expose-debug-as debug --allow-natives-syntax
+// Flags: --expose-debug-as debug
var Debug = debug.Debug;
-
var exception = null;
function listener(event, exec_state, event_data, data) {
if (event != Debug.DebugEvent.Break) return;
try {
- var scope = exec_state.frame().scope(0);
- assertEquals(5, scope.scopeObject().property("i").value().value());
+ assertThrows(() => exec_state.frame(0).evaluate("bar.baz"), ReferenceError);
} catch (e) {
exception = e;
}
}
-function f() {
- eval('var i = 5');
- debugger;
-}
-
-f();
-f();
-
-%OptimizeFunctionOnNextCall(f);
Debug.setListener(listener);
-f();
+(function() {
+ debugger; // bar is still in TDZ at this point.
+ let bar = 1;
+ (x => bar); // force bar to be context-allocated.
+})();
+Debug.setListener(null);
assertNull(exception);
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698