Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1916413002: [debugger] fix crash in debug-evaluate when retrieving values in TDZ. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

[debugger] fix crash in debug-evaluate when retrieving values in TDZ. R=jkummerow@chromium.org BUG=chromium:605581 LOG=N NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-605581.js View 1 1 chunk +9 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yang
4 years, 8 months ago (2016-04-26 13:39:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916413002/20001
4 years, 8 months ago (2016-04-26 13:39:24 UTC) #3
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 8 months ago (2016-04-26 13:39:26 UTC) #5
Jakob Kummerow
LGTM, thanks!
4 years, 8 months ago (2016-04-26 14:02:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916413002/20001
4 years, 8 months ago (2016-04-26 14:04:02 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 14:04:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698