Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1916213002: Plug VariableNameContributor contributor into completion_plugin.dart (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Plug VariableNameContributor contributor into completion_plugin.dart BUG=https://github.com/dart-lang/sdk/issues/24254 R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/086026307bc5dc2ac82311183eb16ad7c21d92f8

Patch Set 1 #

Patch Set 2 : rebase with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
4 years, 8 months ago (2016-04-25 20:51:40 UTC) #2
danrubel
LGTM
4 years, 8 months ago (2016-04-25 20:53:48 UTC) #3
jwren
4 years, 8 months ago (2016-04-25 21:01:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
086026307bc5dc2ac82311183eb16ad7c21d92f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698