Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart

Issue 1916213002: Plug VariableNameContributor contributor into completion_plugin.dart (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rebase with bleeding_edge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analysis_server.src.provisional.completion.dart.plugin; 5 library analysis_server.src.provisional.completion.dart.plugin;
6 6
7 import 'package:analysis_server/src/provisional/completion/completion.dart'; 7 import 'package:analysis_server/src/provisional/completion/completion.dart';
8 import 'package:analysis_server/src/provisional/completion/dart/completion.dart' ; 8 import 'package:analysis_server/src/provisional/completion/dart/completion.dart' ;
9 import 'package:analysis_server/src/provisional/completion/dart/completion_dart. dart'; 9 import 'package:analysis_server/src/provisional/completion/dart/completion_dart. dart';
10 import 'package:analysis_server/src/services/completion/dart/arglist_contributor .dart'; 10 import 'package:analysis_server/src/services/completion/dart/arglist_contributor .dart';
11 import 'package:analysis_server/src/services/completion/dart/combinator_contribu tor.dart'; 11 import 'package:analysis_server/src/services/completion/dart/combinator_contribu tor.dart';
12 import 'package:analysis_server/src/services/completion/dart/completion_manager. dart'; 12 import 'package:analysis_server/src/services/completion/dart/completion_manager. dart';
13 import 'package:analysis_server/src/services/completion/dart/field_formal_contri butor.dart'; 13 import 'package:analysis_server/src/services/completion/dart/field_formal_contri butor.dart';
14 import 'package:analysis_server/src/services/completion/dart/imported_reference_ contributor.dart'; 14 import 'package:analysis_server/src/services/completion/dart/imported_reference_ contributor.dart';
15 import 'package:analysis_server/src/services/completion/dart/inherited_reference _contributor.dart'; 15 import 'package:analysis_server/src/services/completion/dart/inherited_reference _contributor.dart';
16 import 'package:analysis_server/src/services/completion/dart/keyword_contributor .dart'; 16 import 'package:analysis_server/src/services/completion/dart/keyword_contributor .dart';
17 import 'package:analysis_server/src/services/completion/dart/label_contributor.d art'; 17 import 'package:analysis_server/src/services/completion/dart/label_contributor.d art';
18 import 'package:analysis_server/src/services/completion/dart/library_member_cont ributor.dart'; 18 import 'package:analysis_server/src/services/completion/dart/library_member_cont ributor.dart';
19 import 'package:analysis_server/src/services/completion/dart/library_prefix_cont ributor.dart'; 19 import 'package:analysis_server/src/services/completion/dart/library_prefix_cont ributor.dart';
20 import 'package:analysis_server/src/services/completion/dart/local_constructor_c ontributor.dart'; 20 import 'package:analysis_server/src/services/completion/dart/local_constructor_c ontributor.dart';
21 import 'package:analysis_server/src/services/completion/dart/local_library_contr ibutor.dart'; 21 import 'package:analysis_server/src/services/completion/dart/local_library_contr ibutor.dart';
22 import 'package:analysis_server/src/services/completion/dart/local_reference_con tributor.dart'; 22 import 'package:analysis_server/src/services/completion/dart/local_reference_con tributor.dart';
23 import 'package:analysis_server/src/services/completion/dart/named_constructor_c ontributor.dart'; 23 import 'package:analysis_server/src/services/completion/dart/named_constructor_c ontributor.dart';
24 import 'package:analysis_server/src/services/completion/dart/static_member_contr ibutor.dart'; 24 import 'package:analysis_server/src/services/completion/dart/static_member_contr ibutor.dart';
25 import 'package:analysis_server/src/services/completion/dart/type_member_contrib utor.dart'; 25 import 'package:analysis_server/src/services/completion/dart/type_member_contrib utor.dart';
26 import 'package:analysis_server/src/services/completion/dart/uri_contributor.dar t'; 26 import 'package:analysis_server/src/services/completion/dart/uri_contributor.dar t';
27 import 'package:analysis_server/src/services/completion/dart/variable_name_contr ibutor.dart';
27 import 'package:plugin/plugin.dart'; 28 import 'package:plugin/plugin.dart';
28 29
29 /** 30 /**
30 * The shared dart completion plugin instance. 31 * The shared dart completion plugin instance.
31 */ 32 */
32 final DartCompletionPlugin dartCompletionPlugin = new DartCompletionPlugin(); 33 final DartCompletionPlugin dartCompletionPlugin = new DartCompletionPlugin();
33 34
34 class DartCompletionPlugin implements Plugin { 35 class DartCompletionPlugin implements Plugin {
35 /** 36 /**
36 * The simple identifier of the extension point that allows plugins to 37 * The simple identifier of the extension point that allows plugins to
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // Revisit this contributor and these tests 109 // Revisit this contributor and these tests
109 // once DartChangeBuilder API has solidified. 110 // once DartChangeBuilder API has solidified.
110 // registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID, 111 // registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
111 // () => new OverrideContributor()); 112 // () => new OverrideContributor());
112 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID, 113 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
113 () => new StaticMemberContributor()); 114 () => new StaticMemberContributor());
114 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID, 115 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
115 () => new TypeMemberContributor()); 116 () => new TypeMemberContributor());
116 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID, 117 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
117 () => new UriContributor()); 118 () => new UriContributor());
119 registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
120 () => new VariableNameContributor());
118 } 121 }
119 122
120 /** 123 /**
121 * Validate the given extension by throwing an [ExtensionError] if it is not a 124 * Validate the given extension by throwing an [ExtensionError] if it is not a
122 * valid Dart specific completion contributor. 125 * valid Dart specific completion contributor.
123 */ 126 */
124 void _validateDartCompletionContributorExtension(Object extension) { 127 void _validateDartCompletionContributorExtension(Object extension) {
125 if (extension is! DartCompletionContributorFactory) { 128 if (extension is! DartCompletionContributorFactory) {
126 String id = _contributorExtensionPoint.uniqueIdentifier; 129 String id = _contributorExtensionPoint.uniqueIdentifier;
127 throw new ExtensionError( 130 throw new ExtensionError(
128 'Extensions to $id must be a DartCompletionContributorFactory'); 131 'Extensions to $id must be a DartCompletionContributorFactory');
129 } 132 }
130 } 133 }
131 } 134 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698