Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916193004: Tidy up representation of ScrollState::m_data. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
bokan, tdresser
CC:
chromium-reviews, blink-reviews, kenneth.christiansen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up representation of ScrollState::m_data. OwnPtr<> is preferable in this context. R= BUG= Committed: https://crrev.com/89b2f00df2b5bb730f88570c5fa4a673f1adfea9 Cr-Commit-Position: refs/heads/master@{#389781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ScrollState.h View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. nit noticed while passing through.
4 years, 8 months ago (2016-04-26 10:03:05 UTC) #2
tdresser
Whoops, thanks. LGTM
4 years, 8 months ago (2016-04-26 12:07:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916193004/1
4 years, 8 months ago (2016-04-26 14:58:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 15:04:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 15:05:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/89b2f00df2b5bb730f88570c5fa4a673f1adfea9
Cr-Commit-Position: refs/heads/master@{#389781}

Powered by Google App Engine
This is Rietveld 408576698