Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollState.h

Issue 1916193004: Tidy up representation of ScrollState::m_data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/scrolling/ScrollState.h
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollState.h b/third_party/WebKit/Source/core/page/scrolling/ScrollState.h
index 2d77a5083c34f275c4bb81887c5c014a3364332d..050ee6b46e2ed4a6487ce38972c8641e7d5aad0c 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollState.h
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollState.h
@@ -8,13 +8,15 @@
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/CoreExport.h"
-#include "core/dom/Element.h"
#include "core/page/scrolling/ScrollStateInit.h"
#include "platform/scroll/ScrollStateData.h"
+#include "wtf/Forward.h"
#include <deque>
namespace blink {
+class Element;
+
class CORE_EXPORT ScrollState final : public GarbageCollectedFinalized<ScrollState>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
@@ -90,8 +92,9 @@ public:
private:
ScrollState();
- ScrollState(PassOwnPtr<ScrollStateData>);
- PassOwnPtr<ScrollStateData> m_data;
+ explicit ScrollState(PassOwnPtr<ScrollStateData>);
+
+ OwnPtr<ScrollStateData> m_data;
std::deque<int> m_scrollChain;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698