Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1916143002: S390X: [turbofan] Word32 loads should be unsigned. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390X: [turbofan] Word32 loads should be unsigned. TEST=cctest/test-run-load-store/* R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= S390: [interpreter] Heal closures when bytecode array is gone. Port 5c8609de9d597000fdb92dffe954d7ed994488b2 Original commit message: This ensures the InterpreterEntryTrampoline heals code entry fields inside closures when being called without a valid bytecode array. This is preparatory work to allow removal of bytecode when switching some functions to other types of code. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/6382a61059daf167511a224f8760a23473812de6 Cr-Commit-Position: refs/heads/master@{#35779}

Patch Set 1 #

Patch Set 2 : remove previous patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -36 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 17 chunks +14 lines, -31 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-25 19:37:20 UTC) #1
JoranSiu
On 2016/04/25 19:37:20, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-25 19:45:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916143002/20001
4 years, 8 months ago (2016-04-25 19:47:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 20:06:45 UTC) #6
MTBrandyberry
On 2016/04/25 20:06:45, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-25 21:01:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916143002/20001
4 years, 8 months ago (2016-04-25 22:25:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 22:27:48 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 22:30:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6382a61059daf167511a224f8760a23473812de6
Cr-Commit-Position: refs/heads/master@{#35779}

Powered by Google App Engine
This is Rietveld 408576698