Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Side by Side Diff: src/compiler/s390/instruction-selector-s390.cc

Issue 1916143002: S390X: [turbofan] Word32 loads should be unsigned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove previous patchset Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/s390/instruction-scheduler-s390.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 #include "src/s390/frames-s390.h" 9 #include "src/s390/frames-s390.h"
10 10
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 case MachineRepresentation::kWord8: 175 case MachineRepresentation::kWord8:
176 opcode = load_rep.IsSigned() ? kS390_LoadWordS8 : kS390_LoadWordU8; 176 opcode = load_rep.IsSigned() ? kS390_LoadWordS8 : kS390_LoadWordU8;
177 break; 177 break;
178 case MachineRepresentation::kWord16: 178 case MachineRepresentation::kWord16:
179 opcode = load_rep.IsSigned() ? kS390_LoadWordS16 : kS390_LoadWordU16; 179 opcode = load_rep.IsSigned() ? kS390_LoadWordS16 : kS390_LoadWordU16;
180 break; 180 break;
181 #if !V8_TARGET_ARCH_S390X 181 #if !V8_TARGET_ARCH_S390X
182 case MachineRepresentation::kTagged: // Fall through. 182 case MachineRepresentation::kTagged: // Fall through.
183 #endif 183 #endif
184 case MachineRepresentation::kWord32: 184 case MachineRepresentation::kWord32:
185 opcode = kS390_LoadWordS32; 185 opcode = kS390_LoadWordU32;
186 #if V8_TARGET_ARCH_S390X
187 // TODO(john.yan): Remove this mode since s390 do not has this restriction
188 mode = kInt16Imm_4ByteAligned;
189 #endif
190 break; 186 break;
191 #if V8_TARGET_ARCH_S390X 187 #if V8_TARGET_ARCH_S390X
192 case MachineRepresentation::kTagged: // Fall through. 188 case MachineRepresentation::kTagged: // Fall through.
193 case MachineRepresentation::kWord64: 189 case MachineRepresentation::kWord64:
194 opcode = kS390_LoadWord64; 190 opcode = kS390_LoadWord64;
195 mode = kInt16Imm_4ByteAligned; 191 mode = kInt16Imm_4ByteAligned;
196 break; 192 break;
197 #else 193 #else
198 case MachineRepresentation::kWord64: // Fall through. 194 case MachineRepresentation::kWord64: // Fall through.
199 #endif 195 #endif
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 MachineOperatorBuilder::kFloat32RoundTruncate | 1780 MachineOperatorBuilder::kFloat32RoundTruncate |
1785 MachineOperatorBuilder::kFloat64RoundTruncate | 1781 MachineOperatorBuilder::kFloat64RoundTruncate |
1786 MachineOperatorBuilder::kFloat64RoundTiesAway | 1782 MachineOperatorBuilder::kFloat64RoundTiesAway |
1787 MachineOperatorBuilder::kWord32Popcnt | 1783 MachineOperatorBuilder::kWord32Popcnt |
1788 MachineOperatorBuilder::kWord64Popcnt; 1784 MachineOperatorBuilder::kWord64Popcnt;
1789 } 1785 }
1790 1786
1791 } // namespace compiler 1787 } // namespace compiler
1792 } // namespace internal 1788 } // namespace internal
1793 } // namespace v8 1789 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/s390/instruction-scheduler-s390.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698