SkDocument/PDF: new API

SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916093002

Committed: https://skia.googlesource.com/skia/+/4b6566644f704cf9e30c71fa547c9b5915752792

[hal.canary, 2016-04-25 18:49:35]

Description was changed from

==========
SkDocument/PDF: new API

BUG=skia:
==========

to

==========
SkDocument/PDF: new API

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-04-25 18:51:57]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 18:51:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916093002/20001

[hal.canary, 2016-04-25 18:52:29]

Description was changed from

==========
SkDocument/PDF: new API

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
==========

[hal.canary, 2016-04-25 18:52:36]

Patchset #1 (id:1) has been deleted

[hal.canary, 2016-04-25 19:01:31]

halcanary@google.com changed reviewers:
+ reed@google.com, tomhudson@google.com

[hal.canary, 2016-04-25 19:01:32]

PTAL

[commit-bot: I haz the power, 2016-04-25 19:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 19:10:18]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-04-25 19:14:31]

https://codereview.chromium.org/1916093002/diff/20001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1916093002/diff/20001/include/core/SkDocument...
include/core/SkDocument.h:48: SkString title;
why not use skia fField convention?

https://codereview.chromium.org/1916093002/diff/20001/include/core/SkDocument...
include/core/SkDocument.h:125: static SkDocument* CreatePDF(SkWStream*,
We've been adding build flags to guard/hide the older Create methods. Had you
considered that here?

[hal.canary, 2016-04-25 21:46:55]

Description was changed from

==========
SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
==========

to

==========
SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-04-25 21:51:05]

Patchset #2 (id:40001) has been deleted

[hal.canary, 2016-04-25 21:51:33]

https://codereview.chromium.org/1916093002/diff/20001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1916093002/diff/20001/include/core/SkDocument...
include/core/SkDocument.h:48: SkString title;
On 2016/04/25 19:14:30, reed1 wrote:
> why not use skia fField convention?

Done.

https://codereview.chromium.org/1916093002/diff/20001/include/core/SkDocument...
include/core/SkDocument.h:125: static SkDocument* CreatePDF(SkWStream*,
On 2016/04/25 19:14:30, reed1 wrote:
> We've been adding build flags to guard/hide the older Create methods. Had you
> considered that here?

Done.

[hal.canary, 2016-04-26 00:03:30]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 00:03:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916093002/60001

[commit-bot: I haz the power, 2016-04-26 00:05:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 00:05:05]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[hal.canary, 2016-04-26 00:16:35]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-04-26 00:16:42]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-04-26 00:16:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916093002/80001

[commit-bot: I haz the power, 2016-04-26 00:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 00:20:17]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2016-04-26 15:04:32]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 15:04:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916093002/100001

[commit-bot: I haz the power, 2016-04-26 15:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 15:24:56]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-04-26 19:18:16]

reed@ still needs to approve the API, but implementation LGTM.

https://codereview.chromium.org/1916093002/diff/100001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1916093002/diff/100001/include/core/SkDocumen...
include/core/SkDocument.h:13: #include "SkPixelSerializer.h"
Although I've said before that sk_sp<> doesn't work with forward decls,
sometimes it seems that it does - are you *sure* we have to change this to a
full #include?

https://codereview.chromium.org/1916093002/diff/100001/include/core/SkDocumen...
include/core/SkDocument.h:22: #define SK_SUPPORT_LEGACY_DOCUMENT_API
To be migrated into SkUserConfig?

https://codereview.chromium.org/1916093002/diff/100001/src/pdf/SkPDFDocument.cpp
File src/pdf/SkPDFDocument.cpp (right):

https://codereview.chromium.org/1916093002/diff/100001/src/pdf/SkPDFDocument....
src/pdf/SkPDFDocument.cpp:314: for (const auto keyValuePtr : gMetadataKeys) {
Ugh, but I suppose it works and is small.

[hal.canary, 2016-04-26 19:27:58]

https://codereview.chromium.org/1916093002/diff/100001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/1916093002/diff/100001/include/core/SkDocumen...
include/core/SkDocument.h:22: #define SK_SUPPORT_LEGACY_DOCUMENT_API
On 2016/04/26 19:18:16, tomhudson wrote:
> To be migrated into SkUserConfig?

Not necesartily: see SK_SUPPORT_LEGACY_DATA_FACTORIES

[hal.canary, 2016-04-26 19:56:50]

https://codereview.chromium.org/1916093002/diff/100001/src/pdf/SkPDFDocument.cpp
File src/pdf/SkPDFDocument.cpp (right):

https://codereview.chromium.org/1916093002/diff/100001/src/pdf/SkPDFDocument....
src/pdf/SkPDFDocument.cpp:314: for (const auto keyValuePtr : gMetadataKeys) {
On 2016/04/26 19:18:16, tomhudson wrote:
> Ugh, but I suppose it works and is small.

I combined the two tables.  Does that make it better?

[reed1, 2016-04-26 20:10:43]

api lgtm

[hal.canary, 2016-04-26 20:26:47]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 20:26:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916093002/120001

[commit-bot: I haz the power, 2016-04-26 21:19:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:19:59]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-04-27 14:44:09]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-04-27 14:44:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1916093002/#ps120001
(title: "2016-04-26 (Tuesday) 15:55:33 EDT")

[commit-bot: I haz the power, 2016-04-27 14:44:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916093002/120001

[commit-bot: I haz the power, 2016-04-27 14:45:20]

Description was changed from

==========
SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/4b6566644f704cf9e30c71fa547c9b5915752792
==========

[commit-bot: I haz the power, 2016-04-27 14:45:22]

Committed patchset #4 (id:120001) as
https://skia.googlesource.com/skia/+/4b6566644f704cf9e30c71fa547c9b5915752792