SkDocument/PDF: new API

include/core/SkDocument.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkDocument_DEFINED
 #define SkDocument_DEFINED
 
@@ skipping 17 matching lines @@
  *
  *  1. Create a document, specifying a stream to store the output.
  *  2. For each "page" of content:
  *      a. canvas = doc->beginPage(...)
  *      b. draw_my_content(canvas);
  *      c. doc->endPage();
  *  3. Close the document with doc->close().
  */
 class SK_API SkDocument : public SkRefCnt {
 public:
+    struct OptionalTimestamp {
+        bool enabled;
+        SkTime::DateTime dateTime;
+        OptionalTimestamp() : enabled(false) {}
+    };
+
     /**
+     *  Optional metadata to be passed into the PDF factory function.
+     */
+    struct PDFMetadata {
+        SkString title;

[reed1, 2016/04/25 19:14:30]

why not use skia fField convention?

[hal.canary, 2016/04/25 21:51:33]

Done.

+        SkString author;
+        SkString subject;
+        SkString keywords;
+        SkString creator;
+        OptionalTimestamp creation;
+        OptionalTimestamp modified;
+    };
+
+    /**
+     *  Create a PDF-backed document, writing the results into a
+     *  SkWStream.
+     *
+     *  PDF pages are sized in point units. 1 pt == 1/72 inch ==
+     *  127/360 mm.
+     *
+     *  @param stream A PDF document will be written to this
+     *         stream.  The document may write to the stream at
+     *         anytime during its lifetime, until either close() is
+     *         called or the document is deleted.
+     *  @param dpi The DPI (pixels-per-inch) at which features without
+     *         native PDF support will be rasterized (e.g. draw image
+     *         with perspective, draw text with perspective, ...)  A
+     *         larger DPI would create a PDF that reflects the
+     *         original intent with better fidelity, but it can make
+     *         for larger PDF files too, which would use more memory
+     *         while rendering, and it would be slower to be processed
+     *         or sent online or to printer.
+     *  @param metadata a PDFmetadata object.  Any fields may be left
+     *         empty.
+     *  @param jpegEncoder For PDF documents, if a jpegEncoder is set,
+     *         use it to encode SkImages and SkBitmaps as [JFIF]JPEGs.
+     *         This feature is deprecated and is only supplied for
+     *         backwards compatability.
+     *         The prefered method to create PDFs with JPEG images is
+     *         to use SkImage::NewFromEncoded() and not jpegEncoder.
+     *         Chromium uses NewFromEncoded.
+     *         If the encoder is unset, or if jpegEncoder->onEncode()
+     *         returns NULL, fall back on encoding images losslessly
+     *         with Deflate.
+     *  @param pdfa Iff true, include XMP metadata, a document UUID,
+     *         and sRGB output intent information.  This adds length
+     *         to the document and makes it non-reproducable, but are
+     *         necessary features for PDF/A-2b conformance
+     *
+     *  @returns NULL if there is an error, otherwise a newly created
+     *           PDF-backed SkDocument.
+     */
+    static sk_sp<SkDocument> MakePDF(
+            SkWStream* stream,
+            SkScalar dpi,
+            const SkDocument::PDFMetadata& metadata,
+            SkPixelSerializer* jpegEncoder,
+            bool pdfa);
+
+    /**
+     *  DEPRECATED: use SkDocument::MakePDF instead.
+     *
      *  Create a PDF-backed document, writing the results into a SkWStream.
      *
      *  PDF pages are sized in point units. 1 pt == 1/72 inch == 127/360 mm.
      *
      *  @param SkWStream* A PDF document will be written to this
      *         stream.  The document may write to the stream at
      *         anytime during its lifetime, until either close() is
      *         called or the document is deleted.
      *  @param dpi The DPI (pixels-per-inch) at which features without
      *         native PDF support will be rasterized (e.g. draw image
      *         with perspective, draw text with perspective, ...)  A
      *         larger DPI would create a PDF that reflects the
      *         original intent with better fidelity, but it can make
      *         for larger PDF files too, which would use more memory
      *         while rendering, and it would be slower to be processed
      *         or sent online or to printer.
      *  @returns NULL if there is an error, otherwise a newly created
      *           PDF-backed SkDocument.
      */
     static SkDocument* CreatePDF(SkWStream*,

[reed1, 2016/04/25 19:14:30]

We've been adding build flags to guard/hide the older Create methods. Had you
considered that here?

[hal.canary, 2016/04/25 21:51:33]

Done.

                                  SkScalar dpi = SK_ScalarDefaultRasterDPI);
 
     /**
+     *  DEPRECATED: use SkDocument::MakePDF instead.
+     *
      *  @param jpegEncoder For PDF documents, if a jpegEncoder is set,
      *         use it to encode SkImages and SkBitmaps as [JFIF]JPEGs.
      *         This feature is deprecated and is only supplied for
      *         backwards compatability.
      *
      *         The prefered method to create PDFs with JPEG images is
      *         to use SkImage::NewFromEncoded() and not jpegEncoder.
      *         Chromium uses NewFromEncoded.
      *
      *         If the encoder is unset, or if jpegEncoder->onEncode()
      *         returns NULL, fall back on encoding images losslessly
      *         with Deflate.
      */
     static SkDocument* CreatePDF(SkWStream*,
                                  SkScalar dpi,
                                  SkPixelSerializer* jpegEncoder);
 
     /**
+     *  DEPRECATED: use SkDocument::MakePDF instead.
+     *
      *  Create a PDF-backed document, writing the results into a file.
      */
     static SkDocument* CreatePDF(const char outputFilePath[],
                                  SkScalar dpi = SK_ScalarDefaultRasterDPI);
 
     /**
      *  Create a XPS-backed document, writing the results into the stream.
      *  Returns NULL if XPS is not supported.
      */
     static SkDocument* CreateXPS(SkWStream* stream,
@@ skipping 29 matching lines @@
      */
     bool close();
 
     /**
      *  Call abort() to stop producing the document immediately.
      *  The stream output must be ignored, and should not be trusted.
      */
     void abort();
 
     /**
+     *  DEPRECATED: use SkDocument::PDFMetadata and
+     *  SkDocument::MakePDF instead.
+     *
      *  Set the document's metadata, if supported by the document
      *  type.  The creationDate and modifiedDate parameters can be
      *  nullptr.  For example:
      *
      *  SkDocument* make_doc(SkWStream* output) {
      *      std::vector<SkDocument::Attribute> info;
      *      info.emplace_back(SkString("Title"), SkString("..."));
      *      info.emplace_back(SkString("Author"), SkString("..."));
      *      info.emplace_back(SkString("Subject"), SkString("..."));
      *      info.emplace_back(SkString("Keywords"), SkString("..."));
@@ skipping 39 matching lines @@
 
 private:
     SkWStream* fStream;
     void       (*fDoneProc)(SkWStream*, bool aborted);
     State      fState;
 
     typedef SkRefCnt INHERITED;
 };
 
 #endif