Fix unittest with embedded NUL character.

Fix unittest with embedded NUL character.

There is an embedded NUL character (previously line 40).
The test was working because the beginning ot the string is identical.
But, the rest of the string wasn't compare at all.

TESTED: manually

etienneb@burger:~/src/pdfium/pdfium$ out/Debug/pdfium_embeddertests --gtest_filter=*.EmptyCreation
Note: Google Test filter = *.EmptyCreation
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FPDFEditEmbeddertest
[ RUN      ] FPDFEditEmbeddertest.EmptyCreation
[       OK ] FPDFEditEmbeddertest.EmptyCreation (13 ms)
[----------] 1 test from FPDFEditEmbeddertest (13 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (13 ms total)
[  PASSED  ] 1 test.

R=dsinclair
BUG=589955
Committed: https://pdfium.googlesource.com/pdfium/+/7712c26b05c85399afbf8cb3d363836e678ad443

[dsinclair, 2016-04-25 19:32:47]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-04-25 19:32:48]

This looks right to me, tsepez@ can you take a peek that there isn't something
going on I'm missing?

[Tom Sepez, 2016-04-25 20:20:40]

Can we use something besides 'X', maybe something less likely to occur, ctrl-A
\01 for example?

https://codereview.chromium.org/1916083002/diff/20001/fpdfsdk/fpdfedit_embedd...
File fpdfsdk/fpdfedit_embeddertest.cpp (right):

https://codereview.chromium.org/1916083002/diff/20001/fpdfsdk/fpdfedit_embedd...
fpdfsdk/fpdfedit_embeddertest.cpp:34: "x\x9C\x3xxxx\x1\r\n"
Can we add a comment here along the lines of "Not really x, NULs"

[etienneb, 2016-04-25 20:30:31]

What about this?

https://codereview.chromium.org/1916083002/diff/20001/fpdfsdk/fpdfedit_embedd...
File fpdfsdk/fpdfedit_embeddertest.cpp (right):

https://codereview.chromium.org/1916083002/diff/20001/fpdfsdk/fpdfedit_embedd...
fpdfsdk/fpdfedit_embeddertest.cpp:34: "x\x9C\x3xxxx\x1\r\n"
On 2016/04/25 20:20:40, Tom Sepez wrote:
> Can we add a comment here along the lines of "Not really x, NULs"

Which character do you prefer?

. _ ?  \01

I won't maintain this code, so it's your call.


I personally found it hard to read with the \01.
Adding the comments sound good to me.

[Tom Sepez, 2016-04-25 20:35:29]

LGTM.  I'm good with the _.

[Tom Sepez, 2016-04-25 20:35:45]

On 2016/04/25 20:35:29, Tom Sepez wrote:
> LGTM.  I'm good with the _.

(Thanks, btw)

[dsinclair, 2016-04-25 20:36:41]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:36:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916083002/40001

[commit-bot: I haz the power, 2016-04-25 20:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:41:38]

Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Tom Sepez, 2016-04-25 22:31:42]

https://codereview.chromium.org/1916083002/diff/40001/fpdfsdk/fpdfedit_embedd...
File fpdfsdk/fpdfedit_embeddertest.cpp (right):

https://codereview.chromium.org/1916083002/diff/40001/fpdfsdk/fpdfedit_embedd...
fpdfsdk/fpdfedit_embeddertest.cpp:67: EXPECT_THAT(result, testing::MatchesRegex(
Ooops.  Need to make this match the above.

[etienneb, 2016-04-26 15:02:33]

oups! :)

https://codereview.chromium.org/1916083002/diff/40001/fpdfsdk/fpdfedit_embedd...
File fpdfsdk/fpdfedit_embeddertest.cpp (right):

https://codereview.chromium.org/1916083002/diff/40001/fpdfsdk/fpdfedit_embedd...
fpdfsdk/fpdfedit_embeddertest.cpp:67: EXPECT_THAT(result, testing::MatchesRegex(
On 2016/04/25 22:31:42, Tom Sepez wrote:
> Ooops.  Need to make this match the above.

my bad! fixed.

[etienneb, 2016-04-26 15:02:40]

The CQ bit was checked by etienneb@chromium.org

[etienneb, 2016-04-26 15:02:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1916083002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-04-26 15:02:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916083002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916083002/60001

[commit-bot: I haz the power, 2016-04-26 15:13:48]

Description was changed from

==========
Fix unittest with embedded NUL character.

There is an embedded NUL character (previously line 40).
The test was working because the beginning ot the string is identical.
But, the rest of the string wasn't compare at all.

TESTED: manually

etienneb@burger:~/src/pdfium/pdfium$ out/Debug/pdfium_embeddertests
--gtest_filter=*.EmptyCreation
Note: Google Test filter = *.EmptyCreation
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FPDFEditEmbeddertest
[ RUN      ] FPDFEditEmbeddertest.EmptyCreation
[       OK ] FPDFEditEmbeddertest.EmptyCreation (13 ms)
[----------] 1 test from FPDFEditEmbeddertest (13 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (13 ms total)
[  PASSED  ] 1 test.

R=dsinclair
BUG=589955
==========

to

==========
Fix unittest with embedded NUL character.

There is an embedded NUL character (previously line 40).
The test was working because the beginning ot the string is identical.
But, the rest of the string wasn't compare at all.

TESTED: manually

etienneb@burger:~/src/pdfium/pdfium$ out/Debug/pdfium_embeddertests
--gtest_filter=*.EmptyCreation
Note: Google Test filter = *.EmptyCreation
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FPDFEditEmbeddertest
[ RUN      ] FPDFEditEmbeddertest.EmptyCreation
[       OK ] FPDFEditEmbeddertest.EmptyCreation (13 ms)
[----------] 1 test from FPDFEditEmbeddertest (13 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (13 ms total)
[  PASSED  ] 1 test.

R=dsinclair
BUG=589955

Committed:
https://pdfium.googlesource.com/pdfium/+/7712c26b05c85399afbf8cb3d363836e678a...
==========

[commit-bot: I haz the power, 2016-04-26 15:13:49]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/7712c26b05c85399afbf8cb3d363836e678a...