Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: fpdfsdk/fpdfedit_embeddertest.cpp

Issue 1916083002: Fix unittest with embedded NUL character. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/fpdf_edit.h" 5 #include "public/fpdf_edit.h"
6 #include "public/fpdfview.h" 6 #include "public/fpdfview.h"
7 #include "testing/embedder_test.h" 7 #include "testing/embedder_test.h"
8 #include "testing/gmock/include/gmock/gmock-matchers.h" 8 #include "testing/gmock/include/gmock/gmock-matchers.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "testing/test_support.h" 10 #include "testing/test_support.h"
11 11
12 class FPDFEditEmbeddertest : public EmbedderTest, public TestSaver {}; 12 class FPDFEditEmbeddertest : public EmbedderTest, public TestSaver {};
13 13
14 namespace {
15 const char kExpectedPDF[] =
16 "%PDF-1.7\r\n"
17 "%\xA1\xB3\xC5\xD7\r\n"
18 "1 0 obj\r\n"
19 "<</Pages 2 0 R /Type/Catalog>>\r\n"
20 "endobj\r\n"
21 "2 0 obj\r\n"
22 "<</Count 1/Kids\\[ 4 0 R \\]/Type/Pages>>\r\n"
23 "endobj\r\n"
24 "3 0 obj\r\n"
25 "<</CreationDate\\(D:.*\\)/Creator\\(PDFium\\)>>\r\n"
26 "endobj\r\n"
27 "4 0 obj\r\n"
28 "<</Contents 5 0 R /MediaBox\\[ 0 0 640 480\\]"
29 "/Parent 2 0 R /Resources<<>>/Rotate 0/Type/Page"
30 ">>\r\n"
31 "endobj\r\n"
32 "5 0 obj\r\n"
33 "<</Filter/FlateDecode/Length 8>>stream\r\n"
34 // Character '_' is matching '\0' (see comment below).
35 "x\x9C\x3____\x1\r\n"
36 "endstream\r\n"
37 "endobj\r\n"
38 "xref\r\n"
39 "0 6\r\n"
40 "0000000000 65535 f\r\n"
41 "0000000017 00000 n\r\n"
42 "0000000066 00000 n\r\n"
43 "0000000122 00000 n\r\n"
44 "0000000192 00000 n\r\n"
45 "0000000301 00000 n\r\n"
46 "trailer\r\n"
47 "<<\r\n"
48 "/Root 1 0 R\r\n"
49 "/Info 3 0 R\r\n"
50 "/Size 6/ID\\[<.*><.*>\\]>>\r\n"
51 "startxref\r\n"
52 "379\r\n"
53 "%%EOF\r\n";
54 } // namespace
55
14 TEST_F(FPDFEditEmbeddertest, EmptyCreation) { 56 TEST_F(FPDFEditEmbeddertest, EmptyCreation) {
15 EXPECT_TRUE(CreateEmptyDocument()); 57 EXPECT_TRUE(CreateEmptyDocument());
16 FPDF_PAGE page = FPDFPage_New(document(), 1, 640.0, 480.0); 58 FPDF_PAGE page = FPDFPage_New(document(), 1, 640.0, 480.0);
17 EXPECT_NE(nullptr, page); 59 EXPECT_NE(nullptr, page);
18 EXPECT_TRUE(FPDFPage_GenerateContent(page)); 60 EXPECT_TRUE(FPDFPage_GenerateContent(page));
19 EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0)); 61 EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
20 EXPECT_THAT(GetString(), 62
21 testing::MatchesRegex( 63 // The MatchesRegexp doesn't support embedded NUL ('\0') characters. They are
22 "%PDF-1.7\r\n" 64 // replaced by '_' for the purpose of the test.
23 "%\xA1\xB3\xC5\xD7\r\n" 65 std::string result = GetString();
24 "1 0 obj\r\n" 66 std::replace(result.begin(), result.end(), '\0', '_');
25 "<</Pages 2 0 R /Type/Catalog>>\r\n" 67 EXPECT_THAT(result, testing::MatchesRegex(
26 "endobj\r\n" 68 std::string(kExpectedPDF, sizeof(kExpectedPDF))));
27 "2 0 obj\r\n"
28 "<</Count 1/Kids\\[ 4 0 R \\]/Type/Pages>>\r\n"
29 "endobj\r\n"
30 "3 0 obj\r\n"
31 "<</CreationDate\\(D:.*\\)/Creator\\(PDFium\\)>>\r\n"
32 "endobj\r\n"
33 "4 0 obj\r\n"
34 "<</Contents 5 0 R /MediaBox\\[ 0 0 640 480\\]"
35 "/Parent 2 0 R /Resources<<>>/Rotate 0/Type/Page"
36 ">>\r\n"
37 "endobj\r\n"
38 "5 0 obj\r\n"
39 "<</Filter/FlateDecode/Length 8>>stream\r\n"
40 "x\x9C\x3\0\0\0\0\x1\r\n"
41 "endstream\r\n"
42 "endobj\r\n"
43 "xref\r\n"
44 "0 6\r\n"
45 "0000000000 65535 f\r\n"
46 "0000000017 00000 n\r\n"
47 "0000000066 00000 n\r\n"
48 "0000000122 00000 n\r\n"
49 "0000000192 00000 n\r\n"
50 "0000000301 00000 n\r\n"
51 "trailer\r\n"
52 "<<\r\n"
53 "/Root 1 0 R\r\n"
54 "/Info 3 0 R\r\n"
55 "/Size 6/ID\\[<.*><.*>\\]>>\r\n"
56 "startxref\r\n"
57 "379\r\n"
58 "%%EOF\r\n"));
59 FPDFPage_Delete(document(), 1); 69 FPDFPage_Delete(document(), 1);
60 } 70 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698