Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
index 69e5959036ab887a361b839002e384fc55b7c895..9e5233f1ddf40371ab1f155f1c30d442464433dc 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
@@ -43,7 +43,6 @@ public:
void reset();
void discardInjectedScripts();
void reportAllContexts(V8RuntimeAgentImpl*);
- void addInspectedObject(PassOwnPtr<V8RuntimeAgent::Inspectable>);
void releaseObjectGroup(const String16& objectGroup);
void setCustomObjectFormatterEnabled(bool);
@@ -52,6 +51,11 @@ public:
V8HeapProfilerAgent* heapProfilerAgent() override;
V8ProfilerAgent* profilerAgent() override;
V8RuntimeAgent* runtimeAgent() override;
+
+ void addInspectedObject(PassOwnPtr<V8RuntimeAgent::Inspectable>);
+ V8RuntimeAgent::Inspectable* inspectedObject(unsigned num);
+ static const unsigned inspectedObjectBufferSize = 5;
dgozman 2016/04/26 00:24:15 kInspectedObjectBufferSize
kozy 2016/04/26 00:29:48 Done.
+
private:
V8InspectorSessionImpl(V8DebuggerImpl*, int contextGroupId);
@@ -64,6 +68,7 @@ private:
OwnPtr<V8DebuggerAgentImpl> m_debuggerAgent;
OwnPtr<V8HeapProfilerAgentImpl> m_heapProfilerAgent;
OwnPtr<V8ProfilerAgentImpl> m_profilerAgent;
+ protocol::Vector<OwnPtr<V8RuntimeAgent::Inspectable>> m_inspectedObjects;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698