Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
index 8c4aa9b4262554c36d79e84c81838a7685cc08dd..5c18f13f075b39aa4960159c6cb07a0e15f2630f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
@@ -70,7 +70,7 @@ void V8InspectorSessionImpl::reset()
void V8InspectorSessionImpl::discardInjectedScripts()
{
- m_injectedScriptHost->clearInspectedObjects();
+ m_inspectedObjects.clear();
const V8DebuggerImpl::ContextByIdMap* contexts = m_debugger->contextGroup(m_contextGroupId);
if (!contexts)
return;
@@ -116,11 +116,6 @@ InjectedScript* V8InspectorSessionImpl::findInjectedScript(ErrorString* errorStr
return objectId ? findInjectedScript(errorString, objectId->contextId()) : nullptr;
}
-void V8InspectorSessionImpl::addInspectedObject(PassOwnPtr<V8RuntimeAgent::Inspectable> inspectable)
-{
- m_injectedScriptHost->addInspectedObject(inspectable);
-}
-
void V8InspectorSessionImpl::releaseObjectGroup(const String16& objectGroup)
{
const V8DebuggerImpl::ContextByIdMap* contexts = m_debugger->contextGroup(m_contextGroupId);
@@ -162,4 +157,18 @@ void V8InspectorSessionImpl::reportAllContexts(V8RuntimeAgentImpl* agent)
agent->reportExecutionContextCreated(idContext.second);
}
+void V8InspectorSessionImpl::addInspectedObject(PassOwnPtr<V8RuntimeAgent::Inspectable> inspectable)
+{
+ m_inspectedObjects.prepend(inspectable);
+ while (m_inspectedObjects.size() > inspectedObjectBufferSize)
+ m_inspectedObjects.removeLast();
+}
+
+V8RuntimeAgent::Inspectable* V8InspectorSessionImpl::inspectedObject(unsigned num)
+{
+ if (num >= m_inspectedObjects.size())
+ return nullptr;
+ return m_inspectedObjects[num].get();
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698