third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8Console.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index 8c4aa9b4262554c36d79e84c81838a7685cc08dd..362953fa5ca8ff04d756f02313d6a4fed7fd7418 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -70,7 +70,6 @@ void V8InspectorSessionImpl::reset()

void V8InspectorSessionImpl::discardInjectedScripts()

{

- m_injectedScriptHost->clearInspectedObjects();

const V8DebuggerImpl::ContextByIdMap* contexts = m_debugger->contextGroup(m_contextGroupId);

if (!contexts)

return;

@@ -116,11 +115,6 @@ InjectedScript* V8InspectorSessionImpl::findInjectedScript(ErrorString* errorStr

return objectId ? findInjectedScript(errorString, objectId->contextId()) : nullptr;

}

-void V8InspectorSessionImpl::addInspectedObject(PassOwnPtr<V8RuntimeAgent::Inspectable> inspectable)

- m_injectedScriptHost->addInspectedObject(inspectable);

void V8InspectorSessionImpl::releaseObjectGroup(const String16& objectGroup)

{

const V8DebuggerImpl::ContextByIdMap* contexts = m_debugger->contextGroup(m_contextGroupId);