Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
index 4035fd006cfbfd4deabcca275383c1f313b5a588..02fedeeed20b04de88c1f49e5f65584bf0703319 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
@@ -119,11 +119,15 @@ public:
void reportExecutionContextDestroyed(InspectedContext*);
void inspect(PassOwnPtr<protocol::Runtime::RemoteObject> objectToInspect, PassOwnPtr<protocol::DictionaryValue> hints);
+ bool enabled() const { return m_enabled; }
+
PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) override;
PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) override;
void disposeObjectGroup(const String16&) override;
v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* groupName = nullptr) override;
void addInspectedObject(PassOwnPtr<Inspectable>) override;
+ Inspectable* inspectedObject(unsigned num);
+ static const unsigned inspectedObjectBufferSize = 5;
private:
V8InspectorSessionImpl* m_session;
@@ -132,6 +136,7 @@ private:
V8DebuggerImpl* m_debugger;
bool m_enabled;
protocol::HashMap<String16, OwnPtr<v8::Global<v8::Script>>> m_compiledScripts;
+ protocol::Vector<OwnPtr<Inspectable>> m_inspectedObjects;
dgozman 2016/04/25 18:20:29 This goes to session. In fact, all V8RuntimeAgent
kozy 2016/04/25 20:33:26 Done.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698