Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: components/browsing_data_ui/history_notice_utils.cc

Issue 1915983007: Relax the conditions to show the permanent notice about other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browsing_data_ui/history_notice_utils.cc
diff --git a/components/browsing_data_ui/history_notice_utils.cc b/components/browsing_data_ui/history_notice_utils.cc
index 1116c3f283caf34a7b0152915b347d549462d6d7..c1568f2a188375f9629ffe3c3ea73e110fea8a62 100644
--- a/components/browsing_data_ui/history_notice_utils.cc
+++ b/components/browsing_data_ui/history_notice_utils.cc
@@ -23,9 +23,7 @@ void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
if (!sync_service ||
!sync_service->IsSyncActive() ||
sync_service->IsUsingSecondaryPassphrase() ||
- !history_service ||
- (!testing::g_override_other_forms_of_browsing_history_query &&
- !history_service->HasOtherFormsOfBrowsingHistory())) {
+ !history_service) {
callback.Run(false);
return;
}
@@ -37,6 +35,13 @@ void ShouldPopupDialogAboutOtherFormsOfBrowsingHistory(
const ProfileSyncService* sync_service,
history::WebHistoryService* history_service,
base::Callback<void(bool)> callback) {
+ if (!history_service ||
+ (!testing::g_override_other_forms_of_browsing_history_query &&
+ !history_service->HasOtherFormsOfBrowsingHistory())) {
+ callback.Run(false);
+ return;
+ }
+
ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
sync_service, history_service, callback);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698