Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1915903002: [css-grid] Refactor information stored related to column positions (Closed)

Created:
4 years, 8 months ago by Manuel Rego
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Refactor information stored related to column positions In m_columnPositions we were storing position of each column including the alignment offset, always from the logical left, and the border and padding, depending on the direction. This was really confusing as in the case of RTL direction we were adding the offset from the left and the right border and padding. This patches changes it to store always the info from the left, so even in RTL direction we use the left border and padding. This allows us to simplify translateRTLCoordinate() as it doesn't need to care about border and padding anymore. No new tests, no change of behavior. Committed: https://crrev.com/d1c930ed4f146adaa9cf9489afc10719f2f0bfa0 Cr-Commit-Position: refs/heads/master@{#389731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Manuel Rego
4 years, 8 months ago (2016-04-25 11:45:32 UTC) #2
eae
LGTM
4 years, 8 months ago (2016-04-26 01:51:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915903002/1
4 years, 8 months ago (2016-04-26 07:03:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 09:44:55 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 09:46:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1c930ed4f146adaa9cf9489afc10719f2f0bfa0
Cr-Commit-Position: refs/heads/master@{#389731}

Powered by Google App Engine
This is Rietveld 408576698