Issue 191553003: [CSS Shapes] CSS parser accepts trailing position arguments

Issue 191553003: [CSS Shapes] CSS parser accepts trailing position arguments (Closed)

Created:
6 years, 9 months ago by rwlbuis

Modified:
6 years, 9 months ago

Reviewers:
leviw_travelin_and_unemployed, Bear Travis

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Bear Travis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[CSS Shapes] CSS parser accepts trailing position arguments Do not accept the basic shape if there are any trailing arguments in the function list. BUG=350565 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168933

Patch Set 1 #

Patch Set 2 : Upload first version #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -2 lines)			Patch
M	LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-test-utils.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	3 chunks	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

This patch is about more css strictness for shapes, all info is in the bug/issue.

6 years, 9 months ago (2014-03-10 17:33:33 UTC) #1

Bear Travis

seems fine to me. https://codereview.chromium.org/191553003/diff/20001/Source/core/css/parser/CSSPropertyParser.cpp File Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/191553003/diff/20001/Source/core/css/parser/CSSPropertyParser.cpp#newcode4522 Source/core/css/parser/CSSPropertyParser.cpp:4522: Small nit: extra newline added.

6 years, 9 months ago (2014-03-11 00:15:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/191553003/20001

6 years, 9 months ago (2014-03-11 17:04:25 UTC) #6

Message was sent while issue was closed.

Change committed as 168933

Expand Messages | Collapse Messages