Ensure we're operating on the correct texture when generating mipmaps.

Ensure we're operating on the correct texture when generating mipmaps.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915403004

Committed: https://skia.googlesource.com/skia/+/adf4fa6fdef40071ebef11d767c2eb067af77179

[Brian Osman, 2016-04-26 21:23:01]

Description was changed from

==========
Ensure we're operating on the correct texture when generating mipmaps.

BUG=skia:
==========

to

==========
Ensure we're operating on the correct texture when generating mipmaps.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-04-26 21:23:48]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[robertphillips, 2016-04-26 21:31:05]

https://codereview.chromium.org/1915403004/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1915403004/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:3153: if (fHWBoundTextureUniqueIDs[unitIdx] != textureID)
{
How is this not getting called ?

[Brian Osman, 2016-04-26 21:35:02]

https://codereview.chromium.org/1915403004/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1915403004/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:3153: if (fHWBoundTextureUniqueIDs[unitIdx] != textureID)
{
On 2016/04/26 21:31:05, robertphillips wrote:
> How is this not getting called ?

I don't have a test-case that demonstrates this as a problem (I could attempt to
engineer one, if you'd like). It does seem like it would be quite
difficult/unlikely:

- Draw w/texture A on slot 0, w/o mipmap filter, and texture B on slot 1
- Draw w/texture A on slot 0, with mipmaps

I think that in this case, we'd end up generating mipmaps of B, right?

[robertphillips, 2016-04-26 21:52:48]

lgtm

https://codereview.chromium.org/1915403004/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1915403004/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:3153: if (fHWBoundTextureUniqueIDs[unitIdx] != textureID)
{
On 2016/04/26 21:35:02, Brian Osman wrote:
> On 2016/04/26 21:31:05, robertphillips wrote:
> > How is this not getting called ?
> 
> I don't have a test-case that demonstrates this as a problem (I could attempt
to
> engineer one, if you'd like). It does seem like it would be quite
> difficult/unlikely:
> 
> - Draw w/texture A on slot 0, w/o mipmap filter, and texture B on slot 1
> - Draw w/texture A on slot 0, with mipmaps
> 
> I think that in this case, we'd end up generating mipmaps of B, right?

I think you're right.

[Brian Osman, 2016-04-26 23:32:26]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-04-26 23:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915403004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915403004/1

[commit-bot: I haz the power, 2016-04-26 23:48:11]

Description was changed from

==========
Ensure we're operating on the correct texture when generating mipmaps.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Ensure we're operating on the correct texture when generating mipmaps.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/adf4fa6fdef40071ebef11d767c2eb067af77179
==========

[commit-bot: I haz the power, 2016-04-26 23:48:11]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/adf4fa6fdef40071ebef11d767c2eb067af77179