src/gpu/gl/GrGLGpu.cpp - Issue 1915403004: Ensure we're operating on the correct texture when generating mipmaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLGpu.cpp

Issue 1915403004: Ensure we're operating on the correct texture when generating mipmaps. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/gl/GrGLGpu.cpp

diff --git a/src/gpu/gl/GrGLGpu.cpp b/src/gpu/gl/GrGLGpu.cpp

index d259d2fb141e9e2f7cc524f162672387e2804f98..29add839bd636db2032bc9bb7e439e29c991606d 100644

--- a/src/gpu/gl/GrGLGpu.cpp

+++ b/src/gpu/gl/GrGLGpu.cpp

@@ -3197,6 +3197,7 @@ void GrGLGpu::bindTexture(int unitIdx, const GrTextureParams& params, bool dstCo

if (GrTextureParams::kMipMap_FilterMode == filterMode) {

if (texture->texturePriv().mipMapsAreDirty()) {

+ this->setTextureUnit(unitIdx);

GL_CALL(GenerateMipmap(target));

texture->texturePriv().dirtyMipMaps(false);

texture->texturePriv().setMaxMipMapLevel(SkMipMap::ComputeLevelCount(

« no previous file with comments | « no previous file | no next file » | no next file with comments »