Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915403002: ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 2. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 2. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/20412557bd9672d3fe9c9ea85df2e948a4fbd883

Patch Set 1 #

Patch Set 2 : agh #

Patch Set 3 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -64 lines) Patch
M apps/benchmark/benchmark_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/audio_play_test/play_tone.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/audio_play_test/play_wav.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M services/asset_bundle/asset_bundle_apptest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/authentication/accounts_db_manager_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/authentication/main.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M services/clipboard/clipboard_apptest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/contacts/contacts_apptest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/dart/content_handler_main.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/debugger/debugger.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M services/files/files_test_base.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M services/http_server/http_server_apptest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M services/http_server/http_server_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/java_handler/java_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/js/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/js/echo_apptest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/js/network_apptest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/js/pingpong_apptest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M services/media/factory_service/audio_track_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M services/media/factory_service/media_player_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M services/media/factory_service/network_reader_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M services/nacl/sfi/content_handler_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/native_support/process_test_base.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M services/native_viewport/platform_viewport_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/notifications/apptests/notifications_apptest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/prediction/prediction_apptests.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-26 01:29:57 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-26 18:07:56 UTC) #2
viettrungluu
4 years, 8 months ago (2016-04-26 18:16:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
20412557bd9672d3fe9c9ea85df2e948a4fbd883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698