services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc - Issue 1915403002: ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc

Issue 1915403002: ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 2. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: doh Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/asset_bundle/asset_bundle_apptest.cc ('k') | services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc

diff --git a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc

index 6f361f6552181c676d385fcc5ba064624ef6b277..e98a4d310df246965717b15b20026e646566e9bc 100644

--- a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc

+++ b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc

@@ -12,6 +12,7 @@

#include "mojo/public/cpp/application/application_connection.h"

#include "mojo/public/cpp/application/application_impl.h"

#include "mojo/public/cpp/application/application_test_base.h"

+#include "mojo/public/cpp/application/connect.h"

#include "mojo/public/cpp/bindings/strong_binding.h"

#include "mojo/public/cpp/system/data_pipe.h"

#include "mojo/services/authenticating_url_loader_interceptor/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom.h"

@@ -290,9 +291,9 @@ class AuthenticatingURLLoaderInterceptorAppTest

ApplicationTestBase::SetUp();

InitializeNetworkService();

- application_impl()->ConnectToServiceDeprecated(

- "mojo:authenticating_url_loader_interceptor",

- &interceptor_meta_factory_);

+ ConnectToService(application_impl()->shell(),

+ "mojo:authenticating_url_loader_interceptor",

+ GetProxy(&interceptor_meta_factory_));

}

void TearDown() override {

@@ -341,8 +342,8 @@ class AuthenticatingURLLoaderInterceptorAppTest

void InitializeNetworkService() {

network_service_.reset();

- application_impl()->ConnectToServiceDeprecated("mojo:network_service",

- &network_service_);

+ mojo::ConnectToService(application_impl()->shell(), "mojo:network_service",

+ GetProxy(&network_service_));

}

void CloseAuthenticationService() { authentication_service_impl_.reset(); }