Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1915243004: Merge https://codereview.chromium.org/1920033003. (Closed)

Created:
4 years, 8 months ago by Jamie
Modified:
4 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge https://codereview.chromium.org/1920033003. Work around key lookup table version mismatch. Discrepancies between the version of the key lookup table used by Chrome and the one against which the PNaCl plugin is compiled cause keys to go missing in Chromoting. This CL is a quick fix for one recent regression--the longer term fix is to move away from using PPAPI for keyboard events. BUG=606457 Review URL: https://codereview.chromium.org/1920033003 Cr-Commit-Position: refs/heads/master@{#389587} (cherry picked from commit 821b64a7c91900617e4190644052fac8afe54a07) R=garykac@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9c99249ba0adca880b8d4368f313a5508167a1b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M remoting/client/plugin/pepper_input_handler.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jamie
PTAL. Note that this swaps the key names the other way around to the version ...
4 years, 8 months ago (2016-04-26 22:00:41 UTC) #2
garykac
lgtm
4 years, 8 months ago (2016-04-26 22:12:24 UTC) #3
Jamie
4 years, 8 months ago (2016-04-26 22:38:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c99249ba0adca880b8d4368f313a5508167a1b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698