Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1920033003: Work around key lookup table version mismatch. (Closed)

Created:
4 years, 8 months ago by Jamie
Modified:
4 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around key lookup table version mismatch. Discrepancies between the version of the key lookup table used by Chrome and the one against which the PNaCl plugin is compiled cause keys to go missing in Chromoting. This CL is a quick fix for one recent regression--the longer term fix is to move away from using PPAPI for keyboard events. BUG=606457 Committed: https://crrev.com/821b64a7c91900617e4190644052fac8afe54a07 Cr-Commit-Position: refs/heads/master@{#389587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M remoting/client/plugin/pepper_input_handler.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jamie
4 years, 8 months ago (2016-04-25 21:02:15 UTC) #3
garykac
lgtm
4 years, 8 months ago (2016-04-25 21:04:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920033003/1
4 years, 8 months ago (2016-04-25 21:05:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 22:24:33 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 22:27:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/821b64a7c91900617e4190644052fac8afe54a07
Cr-Commit-Position: refs/heads/master@{#389587}

Powered by Google App Engine
This is Rietveld 408576698