Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1915123002: Bug Fix: Resize Event Trigger (M51) (Closed)

Created:
4 years, 8 months ago by qiangchen
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Bug Fix: Resize Event Trigger WebMediaPlayerMS triggers Resize event when the new sized frame enters the player. However, one would need to wait some time (~30 ms) for that frame to be displayed. Thus at the instant when resize is triggered, javascript is still seeing the old size. In this CL, we move the trigger to when |current_frame_| is updated. BUG=604795 Review URL: https://codereview.chromium.org/1895233003 Cr-Commit-Position: refs/heads/master@{#388635} (cherry picked from commit 4089952731e1ad0a6cf83764042d59a41fbc42fe) NOTRY=true NOPRESUBMIT=true

Patch Set 1 : \ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
qiangchen
The merge CL. Can you approve it?
4 years, 8 months ago (2016-04-25 17:13:39 UTC) #4
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-25 17:38:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915123002/20001
4 years, 8 months ago (2016-04-25 21:05:07 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-25 21:05:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915123002/20001
4 years, 8 months ago (2016-04-25 21:20:16 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 21:22:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698