Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Issue 1895233003: Bug Fix: Resize Event Trigger (Closed)

Created:
4 years, 8 months ago by qiangchen
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bug Fix: Resize Event Trigger WebMediaPlayerMS triggers Resize event when the new sized frame enters the player. However, one would need to wait some time (~30 ms) for that frame to be displayed. Thus at the instant when resize is triggered, javascript is still seeing the old size. In this CL, we move the trigger to when |current_frame_| is updated. BUG=604795 Committed: https://crrev.com/4089952731e1ad0a6cf83764042d59a41fbc42fe Cr-Commit-Position: refs/heads/master@{#388635}

Patch Set 1 #

Patch Set 2 : Unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -17 lines) Patch
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 13 chunks +68 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
qiangchen
This CL essentially fixes a bug visible on Hangouts. We did not trigger resize event ...
4 years, 8 months ago (2016-04-19 18:03:58 UTC) #4
qiangchen
This CL essentially fixes a bug visible on Hangouts. We did not trigger resize event ...
4 years, 8 months ago (2016-04-19 18:03:58 UTC) #5
DaleCurtis
Unittest? Otherwise looks good.
4 years, 8 months ago (2016-04-20 19:20:40 UTC) #6
qiangchen
On 2016/04/20 19:20:40, DaleCurtis wrote: > Unittest? Otherwise looks good. Done.
4 years, 8 months ago (2016-04-20 22:16:42 UTC) #7
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-20 23:05:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895233003/20001
4 years, 8 months ago (2016-04-20 23:37:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:29:47 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4089952731e1ad0a6cf83764042d59a41fbc42fe
Cr-Commit-Position: refs/heads/master@{#388635}

Powered by Google App Engine
This is Rietveld 408576698