Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1915033006: Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (Closed)

Created:
4 years, 8 months ago by martiniss
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ ) Hopefully everything will be back to normal now... Original issue's description: > depot_tools: add infra_paths recipe module for infra-specific paths > > Depends on https://codereview.chromium.org/1906323003 > > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300210

Patch Set 1 #

Patch Set 2 : Remove recipes.cfg ? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -548 lines) Patch
M recipe_modules/bot_update/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/bot_update/api.py View 2 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/gclient/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/gclient/api.py View 4 chunks +6 lines, -10 lines 0 comments Download
M recipe_modules/gclient/example.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 1 3 chunks +4 lines, -4 lines 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 1 3 chunks +4 lines, -4 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M recipe_modules/git/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/git/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.py View 3 chunks +2 lines, -3 lines 0 comments Download
M recipe_modules/git/example.expected/basic.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_branch.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_file_name.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_hash.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_ref.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_submodule_update_force.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/can_fail_build.json View 1 13 chunks +13 lines, -13 lines 0 comments Download
M recipe_modules/git/example.expected/cannot_fail_build.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/cat-file_test.json View 1 18 chunks +19 lines, -19 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_delta.json View 1 18 chunks +19 lines, -19 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_failed.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_with_bad_output.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json View 1 8 chunks +8 lines, -8 lines 0 comments Download
M recipe_modules/git/example.expected/curl_trace_file.json View 1 16 chunks +18 lines, -18 lines 0 comments Download
M recipe_modules/git/example.expected/platform_win.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/rebase_failed.json View 1 16 chunks +16 lines, -16 lines 0 comments Download
M recipe_modules/git/example.expected/remote_not_origin.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/set_got_revision.json View 1 16 chunks +17 lines, -17 lines 0 comments Download
D recipe_modules/infra_paths/__init__.py View 1 chunk +0 lines, -5 lines 0 comments Download
D recipe_modules/infra_paths/api.py View 1 chunk +0 lines, -33 lines 0 comments Download
D recipe_modules/infra_paths/config.py View 1 chunk +0 lines, -50 lines 0 comments Download
D recipe_modules/infra_paths/example.py View 1 chunk +0 lines, -24 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/linux.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/linux_kitchen.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/mac.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/mac_kitchen.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/win.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/win_kitchen.json View 1 chunk +0 lines, -12 lines 0 comments Download
M recipe_modules/rietveld/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/rietveld/api.py View 1 chunk +6 lines, -6 lines 0 comments Download
M recipe_modules/rietveld/example.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_modules/rietveld/example.expected/basic.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M recipe_modules/tryserver/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/tryserver/api.py View 1 chunk +1 line, -2 lines 0 comments Download
M recipe_modules/tryserver/example.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_git_patch.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_rietveld_patch.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_svn_patch.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_wrong_patch.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915033006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915033006/1
4 years, 8 months ago (2016-04-26 21:34:53 UTC) #3
commit-bot: I haz the power
Failed to apply patch for infra/config/recipes.cfg: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
4 years, 8 months ago (2016-04-26 21:35:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915033006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915033006/20001
4 years, 8 months ago (2016-04-26 21:40:45 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:41:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300210

Powered by Google App Engine
This is Rietveld 408576698