Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: extensions/browser/app_window/app_window_interactive_uitest.cc

Issue 1914993002: Enhance chrome.app.window API with better shelf integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + Fixes v10 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | extensions/common/api/app_window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window_interactive_uitest.cc
diff --git a/extensions/browser/app_window/app_window_interactive_uitest.cc b/extensions/browser/app_window/app_window_interactive_uitest.cc
index cdf5c4c3296b24288441efc1cdb447d6f40af30a..32fb2b85ec7015763beb6f8d4188c5c0bffe9eb1 100644
--- a/extensions/browser/app_window/app_window_interactive_uitest.cc
+++ b/extensions/browser/app_window/app_window_interactive_uitest.cc
@@ -186,4 +186,17 @@ IN_PROC_BROWSER_TEST_F(AppWindowTest, MAYBE_DisableAlwaysOnTopInFullscreen) {
CloseAppWindow(window);
}
+// Tests a window created with showInShelf property enabled is indeed marked
+// as shown in shelf in AppWindow.
+IN_PROC_BROWSER_TEST_F(AppWindowTest, InitShowInShelf) {
+ AppWindow* window =
+ CreateTestAppWindow("{ \"showInShelf\": true , \"id\": \"window\" }");
+ ASSERT_TRUE(window);
+
+ // Ensure that the window created is marked as shown in shelf.
+ EXPECT_TRUE(window->show_in_shelf());
+
+ CloseAppWindow(window);
+}
+
} // namespace extensions
« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | extensions/common/api/app_window.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698