Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 1914993002: Enhance chrome.app.window API with better shelf integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + Fixes v10 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index f3d2b98a37d92fd51fdf2eec21ceb2bd973fddbe..7df3954b504836f2fd675079e95c4e3afa9bf122 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -173,8 +173,8 @@ AppWindow::CreateParams::CreateParams()
resizable(true),
focused(true),
always_on_top(false),
- visible_on_all_workspaces(false) {
-}
+ visible_on_all_workspaces(false),
+ show_in_shelf(false) {}
AppWindow::CreateParams::CreateParams(const CreateParams& other) = default;
@@ -255,6 +255,7 @@ AppWindow::AppWindow(BrowserContext* context,
cached_always_on_top_(false),
requested_alpha_enabled_(false),
is_ime_window_(false),
+ show_in_shelf_(false),
image_loader_ptr_factory_(this) {
ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
CHECK(!client->IsGuestSession(context) || context->IsOffTheRecord())
@@ -295,8 +296,8 @@ void AppWindow::Init(const GURL& url,
new_params.always_on_top = false;
requested_alpha_enabled_ = new_params.alpha_enabled;
-
is_ime_window_ = params.is_ime_window;
+ show_in_shelf_ = params.show_in_shelf;
AppWindowClient* app_window_client = AppWindowClient::Get();
native_app_window_.reset(
« no previous file with comments | « extensions/browser/app_window/app_window.h ('k') | extensions/browser/app_window/app_window_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698