Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 1914933004: Add missing public_deps for //content/public/app:xxx GN targets. (Closed)

Created:
4 years, 8 months ago by nyquist
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing public_deps for //content/public/app:xxx GN targets. The non-component build version of the //content/public/app:both target provides the public_app_shared_sources as sources, whereas the component build version of the same target does not. This causes issues for targets outside //content that need to depend on //content/public/app/content_main.h and other files in public_app_shared_sources from //content/public/app/BUILD.gn, because the non-component build has to be special cased. This CL fixes the public_deps for //content/public/app:xxx for the component build to make the dependency on //content a public_deps entry. This includes the targets: //content/public/app:browser //content/public/app:child //content/public/app:both BUG=597830 Committed: https://crrev.com/ae6d61aae5d8b33110c93d60bbe746722f5f966a Cr-Commit-Position: refs/heads/master@{#390103}

Patch Set 1 #

Patch Set 2 : git merge origin/master #

Patch Set 3 : Changed //content/public/app:xxx to use public_deps for //content deps #

Patch Set 4 : git merge origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/public/app/BUILD.gn View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
nyquist
dpranke: PTAL
4 years, 8 months ago (2016-04-25 23:29:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914933004/1
4 years, 8 months ago (2016-04-25 23:36:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 00:40:00 UTC) #6
nyquist
brettw: PTAL This is related to the discussion on https://codereview.chromium.org/1922613003
4 years, 8 months ago (2016-04-26 21:27:40 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914933004/60001
4 years, 8 months ago (2016-04-26 21:41:54 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 22:36:32 UTC) #13
brettw
lgtm
4 years, 7 months ago (2016-04-27 05:23:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914933004/60001
4 years, 7 months ago (2016-04-27 16:42:25 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-27 16:46:53 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:10:38 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ae6d61aae5d8b33110c93d60bbe746722f5f966a
Cr-Commit-Position: refs/heads/master@{#390103}

Powered by Google App Engine
This is Rietveld 408576698