Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: content/public/app/BUILD.gn

Issue 1914933004: Add missing public_deps for //content/public/app:xxx GN targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git merge origin/master Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # App different than the regular content subcomponents (see comments in 5 # App different than the regular content subcomponents (see comments in
6 # //content/BUILD.gn) because it has to support the browser/child process split 6 # //content/BUILD.gn) because it has to support the browser/child process split
7 # (the "both" target include both browser and child process files and is used 7 # (the "both" target include both browser and child process files and is used
8 # for testing). 8 # for testing).
9 # 9 #
10 # In non-component mode, browser, child, and both all follow the same structure: 10 # In non-component mode, browser, child, and both all follow the same structure:
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 configs += [ "//content:content_implementation" ] 52 configs += [ "//content:content_implementation" ]
53 53
54 deps = public_app_shared_deps + [ 54 deps = public_app_shared_deps + [
55 "//content/app:both", 55 "//content/app:both",
56 "//content/public/browser:browser_sources", 56 "//content/public/browser:browser_sources",
57 ] 57 ]
58 } 58 }
59 59
60 # These all just forward to content, which in turn depends on "both_sources". 60 # These all just forward to content, which in turn depends on "both_sources".
61 group("browser") { 61 group("browser") {
62 deps = [ 62 public_deps = [
63 "//content", 63 "//content",
64 ] 64 ]
65 } 65 }
66 group("child") { 66 group("child") {
67 deps = [ 67 public_deps = [
68 "//content", 68 "//content",
69 ] 69 ]
70 } 70 }
71 group("both") { 71 group("both") {
72 deps = [ 72 public_deps = [
73 "//content", 73 "//content",
74 ] 74 ]
75 } 75 }
76 } else { 76 } else {
77 # content_main_delegate.cc conditionally includes content_browser_client.h 77 # content_main_delegate.cc conditionally includes content_browser_client.h
78 # from //content/public/browser when it's not the child build. However, 78 # from //content/public/browser when it's not the child build. However,
79 # the header checker doesn't know this doesn't apply and throws an error. 79 # the header checker doesn't know this doesn't apply and throws an error.
80 # So all of these targets set check_includes = false. 80 # So all of these targets set check_includes = false.
81 # 81 #
82 # TODO(brettw) either teach the header checker to understand simple 82 # TODO(brettw) either teach the header checker to understand simple
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 "//media/mojo/services:media_manifest", 154 "//media/mojo/services:media_manifest",
155 "//services/user:manifest", 155 "//services/user:manifest",
156 ] 156 ]
157 } 157 }
158 158
159 mojo_application_manifest("renderer_manifest") { 159 mojo_application_manifest("renderer_manifest") {
160 type = "exe" 160 type = "exe"
161 application_name = "content_renderer" 161 application_name = "content_renderer"
162 source = "mojo/content_renderer_manifest.json" 162 source = "mojo/content_renderer_manifest.json"
163 } 163 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698