Add support for entering/exiting HTML fullscreen from OOPIFs.

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index cc5d4b7645afc52547288c9a68e05182c15ecad1..6e7254a1f588a2724cf6aa1fa6dd4835bad82779 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -194,6 +194,8 @@ void WebFrameWidgetImpl::resizeVisualViewport(const WebSize& newSize)
     // to use Page messages.  https://crbug.com/599688.
     page()->frameHost().visualViewport().setSize(newSize);
     page()->frameHost().visualViewport().clampToBoundaries();
+
+    view()->didUpdateFullScreenSize();

[dcheng, 2016/05/19 22:08:39]

Why do we need to call this here now?

[alexmos, 2016/05/19 23:58:19]

This is needed for things like opening/resizing a devtools page on the side
while in fullscreen mode.
(I put this comment when I first sent out the CL, but it probably got buried)

[dcheng, 2016/05/20 07:01:44]

Hmm. Is WebViewImpl getting this behavior via
WebViewImpl::resizeViewWhileAnchored?

[alexmos, 2016/05/20 17:20:13]

Yes, in the WebViewImpl case, the resizing happens via this path:

#1 0x7f042cfbe1a9 blink::FullscreenController::updateSize()
#2 0x7f042d0ba3f3 blink::WebViewImpl::resizeViewWhileAnchored()
#3 0x7f042d0ba7e2 blink::WebViewImpl::resizeWithTopControls()
#4 0x7f0435a68391 content::RenderViewImpl::ResizeWebWidget()
#5 0x7f0435a8d587 content::RenderWidget::Resize()
#6 0x7f0435a89f22 content::RenderWidget::OnResize()
#7 0x7f0435a685ee content::RenderViewImpl::OnResize()

In the WebFrameWidgetImpl case, the path is:

#1 0x7f2747fc31a9 blink::FullscreenController::updateSize()
#2 0x7f27480bfb84 blink::WebViewImpl::didUpdateFullScreenSize()
#3 0x7f274804c850 blink::WebFrameWidgetImpl::resizeVisualViewport()
#4 0x7f2750a9264e content::RenderWidget::Resize()
#5 0x7f2750a8ef22 content::RenderWidget::OnResize()

When devtools is open/resized in fullscreen (or when there are gold info bars on
top and they get dismissed, etc.), the thing that matters is that
LayoutFullScreen::updateStyle (called from FullscreenController::updateSize)
picks up the new visual viewport, hence the reason why I put the call to
updateSize in resizeVisualViewport for WebFrameWidgetImpl.

(Note that for this scenario in the WebViewImpl case, you might wonder how
things work since it appears that the explicit resizeVisualViewport update in
RenderWidget::Resize() happens after it returns from ResizeWebWidget.  Actually,
on that path the visual viewport is updated from
blink::WebViewImpl::performResize, while in
blink::WebViewImpl::resizeViewWhileAnchored in the stack above, and that happens
before FullscreenController::updateSize.)

 }
 
 void WebFrameWidgetImpl::updateMainFrameLayoutSize()
@@ -218,12 +220,12 @@ void WebFrameWidgetImpl::setIgnoreInputEvents(bool newValue)
 
 void WebFrameWidgetImpl::didEnterFullScreen()
 {
-    // FIXME: Implement full screen for out-of-process iframes.
+    view()->didEnterFullScreen();
 }
 
 void WebFrameWidgetImpl::didExitFullScreen()
 {
-    // FIXME: Implement full screen for out-of-process iframes.
+    view()->didExitFullScreen();
 }
 
 void WebFrameWidgetImpl::beginFrame(double lastFrameTimeMonotonic)