Add support for entering/exiting HTML fullscreen from OOPIFs.

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 176 matching lines @@
         }
     }
 }
 
 void WebFrameWidgetImpl::resizeVisualViewport(const WebSize& newSize)
 {
     // TODO(alexmos, kenrb): resizing behavior such as this should be changed
     // to use Page messages.  https://crbug.com/599688.
     page()->frameHost().visualViewport().setSize(newSize);
     page()->frameHost().visualViewport().clampToBoundaries();
+
+    view()->didUpdateFullScreenSize();

[dcheng, 2016/05/19 22:08:39]

Why do we need to call this here now?

[alexmos, 2016/05/19 23:58:19]

This is needed for things like opening/resizing a devtools page on the side
while in fullscreen mode.
(I put this comment when I first sent out the CL, but it probably got buried)

[dcheng, 2016/05/20 07:01:44]

Hmm. Is WebViewImpl getting this behavior via
WebViewImpl::resizeViewWhileAnchored?

[alexmos, 2016/05/20 17:20:13]

Yes, in the WebViewImpl case, the resizing happens via this path:

#1 0x7f042cfbe1a9 blink::FullscreenController::updateSize()
#2 0x7f042d0ba3f3 blink::WebViewImpl::resizeViewWhileAnchored()
#3 0x7f042d0ba7e2 blink::WebViewImpl::resizeWithTopControls()
#4 0x7f0435a68391 content::RenderViewImpl::ResizeWebWidget()
#5 0x7f0435a8d587 content::RenderWidget::Resize()
#6 0x7f0435a89f22 content::RenderWidget::OnResize()
#7 0x7f0435a685ee content::RenderViewImpl::OnResize()

In the WebFrameWidgetImpl case, the path is:

#1 0x7f2747fc31a9 blink::FullscreenController::updateSize()
#2 0x7f27480bfb84 blink::WebViewImpl::didUpdateFullScreenSize()
#3 0x7f274804c850 blink::WebFrameWidgetImpl::resizeVisualViewport()
#4 0x7f2750a9264e content::RenderWidget::Resize()
#5 0x7f2750a8ef22 content::RenderWidget::OnResize()

When devtools is open/resized in fullscreen (or when there are gold info bars on
top and they get dismissed, etc.), the thing that matters is that
LayoutFullScreen::updateStyle (called from FullscreenController::updateSize)
picks up the new visual viewport, hence the reason why I put the call to
updateSize in resizeVisualViewport for WebFrameWidgetImpl.

(Note that for this scenario in the WebViewImpl case, you might wonder how
things work since it appears that the explicit resizeVisualViewport update in
RenderWidget::Resize() happens after it returns from ResizeWebWidget.  Actually,
on that path the visual viewport is updated from
blink::WebViewImpl::performResize, while in
blink::WebViewImpl::resizeViewWhileAnchored in the stack above, and that happens
before FullscreenController::updateSize.)

 }
 
 void WebFrameWidgetImpl::updateMainFrameLayoutSize()
 {
     if (!m_localRoot)
         return;
 
     FrameView* view = m_localRoot->frameView();
     if (!view)
         return;
 
     WebSize layoutSize = m_size;
 
     view->setLayoutSize(layoutSize);
 }
 
 void WebFrameWidgetImpl::setIgnoreInputEvents(bool newValue)
 {
     DCHECK_NE(m_ignoreInputEvents, newValue);
     m_ignoreInputEvents = newValue;
 }
 
 void WebFrameWidgetImpl::didEnterFullScreen()
 {
-    // FIXME: Implement full screen for out-of-process iframes.
+    view()->didEnterFullScreen();
 }
 
 void WebFrameWidgetImpl::didExitFullScreen()
 {
-    // FIXME: Implement full screen for out-of-process iframes.
+    view()->didExitFullScreen();
 }
 
 void WebFrameWidgetImpl::beginFrame(double lastFrameTimeMonotonic)
 {
     TRACE_EVENT1("blink", "WebFrameWidgetImpl::beginFrame", "frameTime", lastFrameTimeMonotonic);
     DCHECK(lastFrameTimeMonotonic);
     PageWidgetDelegate::animate(*page(), lastFrameTimeMonotonic);
 }
 
 void WebFrameWidgetImpl::updateAllLifecyclePhases()
@@ skipping 853 matching lines @@
 
 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& posInRootFrame)
 {
     IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRootFrame));
     HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtPoint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);
     result.setToShadowHostIfInUserAgentShadowRoot();
     return result;
 }
 
 } // namespace blink