Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4862)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index e7704649b5bad3349b00cd37a5e1bef59fbe5c0a..a8941f4d90d031c0b7408e684207918c1455ab7d 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1449,6 +1449,7 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
OnSetFrameOwnerProperties)
IPC_MESSAGE_HANDLER(FrameMsg_AdvanceFocus, OnAdvanceFocus)
IPC_MESSAGE_HANDLER(FrameMsg_SetFocusedFrame, OnSetFocusedFrame)
+ IPC_MESSAGE_HANDLER(FrameMsg_WillEnterFullscreen, OnWillEnterFullscreen)
IPC_MESSAGE_HANDLER(FrameMsg_SetTextTrackSettings,
OnTextTrackSettingsChanged)
IPC_MESSAGE_HANDLER(FrameMsg_PostMessageEvent, OnPostMessageEvent)
@@ -2035,6 +2036,18 @@ void RenderFrameImpl::OnSetFocusedFrame() {
render_view_->webview()->focusDocumentView(frame_);
}
+void RenderFrameImpl::OnWillEnterFullscreen(int fullscreen_frame_routing_id) {
+ RenderFrameProxy* fullscreen_frame =
+ RenderFrameProxy::FromRoutingID(fullscreen_frame_routing_id);
+
+ // The proxy could have been detached just as its real frame was entering
+ // fullscreen.
+ if (!fullscreen_frame)
+ return;
+
+ render_view_->webview()->willEnterFullScreen(fullscreen_frame->web_frame());
Charlie Reis 2016/05/12 22:59:23 This method doesn't seem to act on |this| at all.
alexmos 2016/05/13 07:21:03 Done.
+}
+
void RenderFrameImpl::OnTextTrackSettingsChanged(
const FrameMsg_TextTrackSettings_Params& params) {
DCHECK(!frame_->parent());

Powered by Google App Engine
This is Rietveld 408576698