Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 267eeb8e5360f38c727800484ca4396897bf36ff..91010161d1e5cdeaf24bb34b8b2612c9bb16852e 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1865,9 +1865,6 @@ void WebContentsImpl::ExitFullscreenMode(bool will_cause_resize) {
bool WebContentsImpl::IsFullscreenForCurrentTab(
RenderWidgetHostImpl* render_widget_host) const {
- if (!RenderViewHostImpl::From(render_widget_host))
alexmos 2016/05/10 21:36:24 Removing this allows subframe widgets to pick up t
Charlie Reis 2016/05/12 22:59:23 Ok. Let's put a TODO to remove it.
- return false;
-
return delegate_ ? delegate_->IsFullscreenForTabOrPending(this) : false;
}

Powered by Google App Engine
This is Rietveld 408576698