content/test/data/frame_tree/page_with_one_frame.html - Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/frame_tree/page_with_one_frame.html

Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | content/test/data/fullscreen_frame.html » ('j') | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 function addFrame(url, sandbox) {	5 function addFrame(url, sandbox) {

6 var frame = document.createElement('iframe');	6 var frame = document.createElement('iframe');

7 frame.src = url;	7 frame.src = url;

8 if (sandbox)	8 if (sandbox)

9 frame.sandbox = sandbox;	9 frame.sandbox = sandbox;

10 document.body.appendChild(frame);	10 document.body.appendChild(frame);

11 }	11 }

12 </script>	12 </script>

13 </head>	13 </head>

14 <body>	14 <body>

15 This page has one cross-site iframe.	15 This page has one cross-site iframe.

16 <iframe id="child0" src="/cross-site/baz.com/title1.html"></iframe>	16 <iframe id="child0" src="/cross-site/baz.com/title1.html" allowfullscreen=true ></iframe>
	Charlie Reis 2016/05/12 22:59:23 This is kind of unrelated to most of the tests tha This is kind of unrelated to most of the tests that use this file. Is it possible to do this programmatically from the test where you need it? alexmos 2016/05/13 07:21:03 Ah, this is actually first introduced in my test i Show quoted text On 2016/05/12 22:59:23, Charlie Reis (slow to reply) wrote: > This is kind of unrelated to most of the tests that use this file. Is it > possible to do this programmatically from the test where you need it? Ah, this is actually first introduced in my test in the allowFullscreen replication CL, so that we have coverage for the static <iframe allowfullscreen> case in addition to the dynamic one: https://codereview.chromium.org/1938753002/diff/100001/content/test/data/fram... so this was going to go away once I rebase on that CL, but your point still stands. I can add a new html test file with just the static flag, but I'll probably do that in the replication CL, and then I can reuse the file here. Would that be ok? Charlie Reis 2016/05/13 20:12:14 Yep, thanks. Show quoted text On 2016/05/13 07:21:03, alexmos wrote: > On 2016/05/12 22:59:23, Charlie Reis (slow to reply) wrote: > > This is kind of unrelated to most of the tests that use this file. Is it > > possible to do this programmatically from the test where you need it? > > Ah, this is actually first introduced in my test in the allowFullscreen > replication CL, so that we have coverage for the static <iframe allowfullscreen> > case in addition to the dynamic one: > https://codereview.chromium.org/1938753002/diff/100001/content/test/data/fram... > > so this was going to go away once I rebase on that CL, but your point still > stands. I can add a new html test file with just the static flag, but I'll > probably do that in the replication CL, and then I can reuse the file here. > Would that be ok? Yep, thanks.
17 </body>	17 </body>

18 </html>	18 </html>

OLD	NEW