content/test/data/frame_tree/page_with_one_frame.html - Issue 1938753002: OOPIF: Replicate allowFullscreen flag.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/frame_tree/page_with_one_frame.html

Issue 1938753002: OOPIF: Replicate allowFullscreen flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only send non-default FrameOwnerProperties to new proxies Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 function addFrame(url, sandbox) {	5 function addFrame(url, sandbox) {

6 var frame = document.createElement('iframe');	6 var frame = document.createElement('iframe');

7 frame.src = url;	7 frame.src = url;

8 if (sandbox)	8 if (sandbox)

9 frame.sandbox = sandbox;	9 frame.sandbox = sandbox;

10 document.body.appendChild(frame);	10 document.body.appendChild(frame);

11 }	11 }

12 </script>	12 </script>

13 </head>	13 </head>

14 <body>	14 <body>

15 This page has one cross-site iframe.	15 This page has one cross-site iframe.

16 <iframe id="child0" src="/cross-site/baz.com/title1.html"></iframe>	16 <iframe id="child0" src="/cross-site/baz.com/title1.html" allowFullscreen></if rame>
	Charlie Reis 2016/05/13 21:18:42 As mentioned on the other CL, we might want a full As mentioned on the other CL, we might want a fullscreen test page with this flag, since this bit is unrelated to how this file is used in other tests. alexmos 2016/05/14 01:12:37 Done. Show quoted text On 2016/05/13 21:18:42, Charlie Reis (slow to reply) wrote: > As mentioned on the other CL, we might want a fullscreen test page with this > flag, since this bit is unrelated to how this file is used in other tests. Done.
17 </body>	17 </body>

18 </html>	18 </html>

OLD	NEW