content/browser/renderer_host/render_widget_host_impl.h - Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_guest.h ('K') | « content/browser/frame_host/render_widget_host_view_guest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | content/browser/renderer_host/render_widget_host_view_mus.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.h

diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h

index 1a5f782a0abb24a25c8987d7c0a01c3290d329f7..43047c22be768ba223fe3535c9fee9d8a387e563 100644

--- a/content/browser/renderer_host/render_widget_host_impl.h

+++ b/content/browser/renderer_host/render_widget_host_impl.h

@@ -48,7 +48,7 @@

struct FrameHostMsg_HittestData_Params;

struct ViewHostMsg_SelectionBounds_Params;

-struct ViewHostMsg_TextInputState_Params;

+struct TextInputState;

Charlie Reis 2016/04/22 23:02:38 nit: Belongs in content namespace. (Same in remai

EhsanK 2016/04/25 19:09:00 Done.

struct ViewHostMsg_UpdateRect_Params;

namespace base {

@@ -571,8 +571,7 @@ class CONTENT_EXPORT RenderWidgetHostImpl : public RenderWidgetHost,

void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);

void OnQueueSyntheticGesture(const SyntheticGesturePacket& gesture_packet);

void OnSetCursor(const WebCursor& cursor);

- void OnTextInputStateChanged(

- const ViewHostMsg_TextInputState_Params& params);

+ void OnTextInputStateChanged(const TextInputState& params);

void OnImeCompositionRangeChanged(

const gfx::Range& range,